session BUGFIX do not communicate on invalid sessions

Author: michalvasko

src/session.c

@@ -683,12 +683,12 @@ nc_session_free(struct nc_session *session, void (*data_free)(void *))
             nc_session_client_msgs_unlock(session, __func__);
         }
 
-        /* receive any leftover messages */
-        while (nc_read_msg_poll_io(session, 0, &msg) == 1) {
-            ly_in_free(msg, 1);
-        }
-
         if (session->status == NC_STATUS_RUNNING) {
+            /* receive any leftover messages */
+            while (nc_read_msg_poll_io(session, 0, &msg) == 1) {
+                ly_in_free(msg, 1);
+            }
+
             /* send closing info to the other side */
             ietfnc = ly_ctx_get_module_implemented(session->ctx, "ietf-netconf");
             if (!ietfnc) {

tests/client/test_client_ssh.c

@@ -628,7 +628,6 @@ test_nc_connect_connection_failed(void **state)
     errno = ECONNREFUSED;
     will_return(__wrap_connect, -1);
     will_return(__wrap_ssh_is_connected, 0);
-    will_return(__wrap_ssh_channel_poll_timeout, 0);
 
     session = nc_connect_ssh("127.0.0.1", 8080, NULL);
     assert_null(session);
@@ -658,7 +657,6 @@ test_nc_connect_ssh_bad_hello(void **state)
     will_return(__wrap_ssh_channel_open_session, 0);
     will_return(__wrap_ssh_channel_request_subsystem, 0);
     will_return(__wrap_nc_handshake_io, 4);
-    will_return(__wrap_ssh_channel_poll_timeout, 0);
 
     session = nc_connect_ssh("127.0.0.1", 8080, NULL);
     assert_null(session);