alloca.h not found (freebsd 14.3)

[paigeadelethompson]

➜  build git:(master) cmake ..
-- The C compiler identification is Clang 19.1.7
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
CMake Warning at CMakeLists.txt:178 (message):
  valgrind executable not found! Disabling memory leaks tests.


-- Could NOT find CMocka (missing: CMOCKA_LIBRARIES CMOCKA_INCLUDE_DIR) (Required is at least version "1.0.1")
-- Disabling tests because of missing CMocka
-- Could NOT find Uncrustify (missing: UNCRUSTIFY) (Required is at least version "0.77")
-- Looking for _POSIX_TIMERS
-- Looking for _POSIX_TIMERS - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
-- Looking for pthread_mutex_timedlock
-- Looking for pthread_mutex_timedlock - found
-- Looking for pthread_mutex_clocklock
-- Looking for pthread_mutex_clocklock - not found
-- Looking for pthread_rwlock_timedrdlock
-- Looking for pthread_rwlock_timedrdlock - found
-- Looking for pthread_rwlock_clockrdlock
-- Looking for pthread_rwlock_clockrdlock - not found
-- Looking for pthread_rwlock_timedwrlock
-- Looking for pthread_rwlock_timedwrlock - found
-- Looking for pthread_rwlock_clockwrlock
-- Looking for pthread_rwlock_clockwrlock - not found
-- Looking for pthread_cond_clockwait
-- Looking for pthread_cond_clockwait - not found
-- Looking for vdprintf
-- Looking for vdprintf - found
-- Looking for asprintf
-- Looking for asprintf - found
-- Looking for vasprintf
-- Looking for vasprintf - found
-- Looking for getline
-- Looking for getline - found
-- Looking for strndup
-- Looking for strndup - found
-- Looking for strnstr
-- Looking for strnstr - found
-- Looking for strdupa
-- Looking for strdupa - not found
-- Looking for strchrnul
-- Looking for strchrnul - found
-- Looking for get_current_dir_name
-- Looking for get_current_dir_name - not found
-- Looking for timegm
-- Looking for timegm - found
-- Looking for crypt.h
-- Looking for crypt.h - not found
-- Looking for crypt_r
-- Looking for crypt_r - not found
-- Looking for stdatomic.h
-- Looking for stdatomic.h - found
-- Looking for pthread_rwlockattr_setkind_np
-- Looking for pthread_rwlockattr_setkind_np - not found
-- Looking for shadow.h
-- Looking for shadow.h - not found
-- Looking for termios.h
-- Looking for termios.h - found
-- Could NOT find MbedTLS (missing: MBEDTLS_INCLUDE_DIRS MBEDTLS_LIBRARIES) (Required is at least version "3.5.0")
-- Found OpenSSL: /usr/lib/libcrypto.so (found suitable version "3.0.16", minimum required is "3.0.0")
-- Found LibSSH: /usr/local/include (found suitable version "0.11.2", minimum required is "0.9.5")
-- Found CURL: /usr/local/lib/libcurl.so (found suitable version "8.14.1", minimum required is "7.30.0")
-- Looking for crypt in crypt
-- Looking for crypt in crypt - found
-- Found LibPAM: /usr/lib/libpam.so
-- SSH Keyboard Interactive system method: Linux PAM
-- Found LibYANG: /usr/local/lib/libyang.so (found suitable version "3.9.1", minimum required is "3.9.0")
-- Found PkgConfig: /usr/local/bin/pkg-config (found version "2.4.3")
CMake Warning at CMakeLists.txt:361 (message):
  pkg-config will not detect the new package after installation, adjust
  PKG_CONFIG_PATH using "export
  PKG_CONFIG_PATH=${PKG_CONFIG_PATH}:lib/pkgconfig".


-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) 
-- Configuring done (2.0s)
-- Generating done (0.0s)
-- Build files have been written to: /home/sq/libnetconf2/build
➜  build git:(master) make -j8
[  8%] Building C object CMakeFiles/netconf2.dir/src/messages_server.c.o
[  8%] Building C object CMakeFiles/netconf2.dir/src/session_server.c.o
[ 12%] Building C object CMakeFiles/netconf2.dir/src/session.c.o
[ 16%] Building C object CMakeFiles/netconf2.dir/src/messages_client.c.o
[ 20%] Building C object CMakeFiles/netconf2.dir/src/log.c.o
[ 25%] Building C object CMakeFiles/netconf2.dir/src/server_config.c.o
[ 33%] Building C object CMakeFiles/netconf2.dir/src/io.c.o
[ 29%] Building C object CMakeFiles/netconf2.dir/src/session_client.c.o
In file included from /home/sq/libnetconf2/src/log.c:19:
In file included from /home/sq/libnetconf2/src/log_p.h:22:
/home/sq/libnetconf2/build/compat/compat.h:26:10: fatal error: 'alloca.h' file not found
   26 | #include <alloca.h>
      |          ^~~~~~~~~~
In file included from /home/sq/libnetconf2/src/session_server.c:36:
In file included from /home/sq/libnetconf2/src/io.c:34:
/home/sq/libnetconf2/build/compat/compat.h:26:10: fatal error: 'alloca.h' file not found
   26 | #include <alloca.h>
      |          ^~~~~~~~~~
In file included from /home/sq/libnetconf2/src/messages_client.c:25:
/home/sq/libnetconf2/build/compat/compat.h:26:10: fatal error: 'alloca.h' file not found
   26 | #include <alloca.h>
      |          ^~~~~~~~~~
In file included from /home/sq/libnetconf2/src/messages_server.c:26:
/home/sq/libnetconf2/build/compat/compat.h:26:10: fatal error: 'alloca.h' file not found
   26 | #include <alloca.h>
      |          ^~~~~~~~~~
In file included from /home/sq/libnetconf2/src/session.c:32:
/home/sq/libnetconf2/build/compat/compat.h:26:10: fatal error: 'alloca.h' file not found
   26 | #include <alloca.h>
      |          ^~~~~~~~~~
/home/sq/libnetconf2/build/compat/compat.h:26:10: fatal error: 'alloca.h' file not found
   26 | #include <alloca.h>
      |          ^~~~~~~~~~
In file included from /home/sq/libnetconf2/src/server_config.c:29:
/home/sq/libnetconf2/build/compat/compat.h:26:10: fatal error: 'alloca.h' file not found
   26 | #include <alloca.h>
      |          ^~~~~~~~~~
In file included from /home/sq/libnetconf2/src/session_client.c:47:
/home/sq/libnetconf2/build/compat/compat.h:26:10: fatal error: 'alloca.h' file not found
   26 | #include <alloca.h>
      |          ^~~~~~~~~~
1 error generated.
--- CMakeFiles/netconf2.dir/src/messages_server.c.o ---
*** [CMakeFiles/netconf2.dir/src/messages_server.c.o] Error code 1

make[2]: stopped in /home/sq/libnetconf2/build
1 error generated.
--- CMakeFiles/netconf2.dir/src/messages_client.c.o ---
*** [CMakeFiles/netconf2.dir/src/messages_client.c.o] Error code 1

make[2]: stopped in /home/sq/libnetconf2/build
1 error generated.
--- CMakeFiles/netconf2.dir/src/log.c.o ---
*** [CMakeFiles/netconf2.dir/src/log.c.o] Error code 1

make[2]: stopped in /home/sq/libnetconf2/build
1 error generated.
--- CMakeFiles/netconf2.dir/src/io.c.o ---
*** [CMakeFiles/netconf2.dir/src/io.c.o] Error code 1

make[2]: stopped in /home/sq/libnetconf2/build
1 error generated.
--- CMakeFiles/netconf2.dir/src/session.c.o ---
*** [CMakeFiles/netconf2.dir/src/session.c.o] Error code 1

make[2]: stopped in /home/sq/libnetconf2/build
1 error generated.
--- CMakeFiles/netconf2.dir/src/server_config.c.o ---
*** [CMakeFiles/netconf2.dir/src/server_config.c.o] Error code 1

make[2]: stopped in /home/sq/libnetconf2/build
1 error generated.
--- CMakeFiles/netconf2.dir/src/session_server.c.o ---
*** [CMakeFiles/netconf2.dir/src/session_server.c.o] Error code 1

make[2]: stopped in /home/sq/libnetconf2/build
1 error generated.
--- CMakeFiles/netconf2.dir/src/session_client.c.o ---
*** [CMakeFiles/netconf2.dir/src/session_client.c.o] Error code 1

make[2]: stopped in /home/sq/libnetconf2/build
8 errors

make[2]: stopped in /home/sq/libnetconf2/build
--- CMakeFiles/netconf2.dir/all ---
*** [CMakeFiles/netconf2.dir/all] Error code 2

make[1]: stopped in /home/sq/libnetconf2/build
1 error

make[1]: stopped in /home/sq/libnetconf2/build
*** [all] Error code 2

make: stopped in /home/sq/libnetconf2/build
1 error

make: stopped in /home/sq/libnetconf2/build
➜  build git:(master) find . -name 
➜  build git:(master) cd ..
➜  libnetconf2 git:(master) ls
CMakeLists.txt        FAQ.md                SECURITY.md           distro                modules               src
CMakeModules          FindLibNETCONF2.cmake build                 doc                   nc_client.h.in        tests
CODINGSTYLE.md        LICENSE               codecov.yml           examples              nc_server.h.in        uncrustify.cfg
Doxyfile.in           README.md             compat                libnetconf2.pc.in     nc_version.h.in
➜  libnetconf2 git:(master) find . -name "alloca.h"
➜  libnetconf2 git:(master) 

FreeBSD steelseries.netcrave.local 14.3-RELEASE FreeBSD 14.3-RELEASE releng/14.3-n271432-8c9ce319fef7 GENERIC amd64

[paigeadelethompson]

There's a couple of different alloca.h files on here (they're not all the same)

➜  libnetconf2 git:(master) sudo find / -name "alloca.h"
/usr/src/contrib/ofed/libibverbs/alloca.h
/usr/src/cddl/compat/opensolaris/include/alloca.h
/usr/local/include/schily/alloca.h
/usr/local/xtensa-esp-elf/xtensa-esp-elf/include/alloca.h
/compat/linux/usr/include/alloca.h

[paigeadelethompson]

same thing in v3.7.1

➜  build git:(v3.7.1) make -j4
[ 16%] Building C object CMakeFiles/netconf2.dir/src/log.c.o
[ 16%] Building C object CMakeFiles/netconf2.dir/src/messages_client.c.o
[  8%] Building C object CMakeFiles/netconf2.dir/src/messages_server.c.o
[ 16%] Building C object CMakeFiles/netconf2.dir/src/io.c.o
In file included from /home/sq/libnetconf2/src/log.c:19:
In file included from /home/sq/libnetconf2/src/log_p.h:22:
/home/sq/libnetconf2/build/compat/compat.h:26:10: fatal error: 'alloca.h' file not found
   26 | #include <alloca.h>

[paigeadelethompson]

I could remove the include from the compat/compat.h.in and that gets me a little farther but now I'm redefining crypt_data:

➜  build git:(v3.7.1) ✗ make -j8
[ 33%] Building C object CMakeFiles/netconf2.dir/src/io.c.o
[ 33%] Building C object CMakeFiles/netconf2.dir/src/messages_client.c.o
[ 33%] Building C object CMakeFiles/netconf2.dir/src/messages_server.c.o
[ 33%] Building C object CMakeFiles/netconf2.dir/src/session.c.o
[  8%] Building C object CMakeFiles/netconf2.dir/src/session_server.c.o
[ 33%] Building C object CMakeFiles/netconf2.dir/src/server_config.c.o
[ 33%] Building C object CMakeFiles/netconf2.dir/src/log.c.o
[ 33%] Building C object CMakeFiles/netconf2.dir/src/session_client.c.o
In file included from /home/sq/libnetconf2/src/log.c:19:
In file included from /home/sq/libnetconf2/src/log_p.h:22:
/home/sq/libnetconf2/build/compat/compat.h:219:8: error: redefinition of 'crypt_data'
  219 | struct crypt_data {
      |        ^
/usr/include/unistd.h:488:8: note: previous definition is here
  488 | struct crypt_data {
      |        ^
In file included from /home/sq/libnetconf2/src/messages_server.c:26:
/home/sq/libnetconf2/build/compat/compat.h:219:8: error: redefinition of 'crypt_data'
  219 | struct crypt_data {
      |        ^
/usr/include/unistd.h:488:8: note: previous definition is here
  488 | struct crypt_data {
      |        ^
1 error generated.
--- CMakeFiles/netconf2.dir/src/messages_server.c.o ---
*** [CMakeFiles/netconf2.dir/src/messages_server.c.o] Error code 1

make[2]: stopped in /home/sq/libnetconf2/build
In file included from /home/sq/libnetconf2/src/io.c:34:
/home/sq/libnetconf2/build/compat/compat.h:219:8: error: redefinition of 'crypt_data'
  219 | struct crypt_data {
      |        ^
/usr/include/unistd.h:488:8: note: previous definition is here
  488 | struct crypt_data {
      |        ^
In file included from /home/sq/libnetconf2/src/messages_client.c:25:
/home/sq/libnetconf2/build/compat/compat.h:219:8: error: redefinition of 'crypt_data'
  219 | struct crypt_data {
      |        ^
/usr/include/unistd.h:488:8: note: previous definition is here
  488 | struct crypt_data {
      |        ^
In file included from /home/sq/libnetconf2/src/server_config.c:29:
/home/sq/libnetconf2/build/compat/compat.h:219:8: error: redefinition of 'crypt_data'
  219 | struct crypt_data {
      |        ^
/usr/include/unistd.h:488:8: note: previous definition is here
  488 | struct crypt_data {
      |        ^
In file included from /home/sq/libnetconf2/src/session.c:32:
/home/sq/libnetconf2/build/compat/compat.h:219:8: error: redefinition of 'crypt_data'
  219 | struct crypt_data {
      |        ^
/usr/include/unistd.h:488:8: note: previous definition is here
  488 | struct crypt_data {
      |        ^
In file included from /home/sq/libnetconf2/src/session_client.c:47:
/home/sq/libnetconf2/build/compat/compat.h:219:8: error: redefinition of 'crypt_data'
  219 | struct crypt_data {
      |        ^
/usr/include/unistd.h:488:8: note: previous definition is here
  488 | struct crypt_data {
      |        ^
In file included from /home/sq/libnetconf2/src/session_server.c:36:
/home/sq/libnetconf2/build/compat/compat.h:219:8: error: redefinition of 'crypt_data'
  219 | struct crypt_data {
      |        ^
/usr/include/unistd.h:488:8: note: previous definition is here
  488 | struct crypt_data {
      |        ^
1 error generated.
--- CMakeFiles/netconf2.dir/src/messages_client.c.o ---
*** [CMakeFiles/netconf2.dir/src/messages_client.c.o] Error code 1

make[2]: stopped in /home/sq/libnetconf2/build
1 error generated.
--- CMakeFiles/netconf2.dir/src/log.c.o ---
*** [CMakeFiles/netconf2.dir/src/log.c.o] Error code 1

make[2]: stopped in /home/sq/libnetconf2/build
1 error generated.
--- CMakeFiles/netconf2.dir/src/session_server.c.o ---
*** [CMakeFiles/netconf2.dir/src/session_server.c.o] Error code 1

make[2]: stopped in /home/sq/libnetconf2/build
1 error generated.
1 error generated.
--- CMakeFiles/netconf2.dir/src/session.c.o ---
*** [CMakeFiles/netconf2.dir/src/session.c.o] Error code 1

make[2]: stopped in /home/sq/libnetconf2/build
--- CMakeFiles/netconf2.dir/src/io.c.o ---
*** [CMakeFiles/netconf2.dir/src/io.c.o] Error code 1

make[2]: stopped in /home/sq/libnetconf2/build
1 error generated.
--- CMakeFiles/netconf2.dir/src/server_config.c.o ---
*** [CMakeFiles/netconf2.dir/src/server_config.c.o] Error code 1

make[2]: stopped in /home/sq/libnetconf2/build
1 error generated.
--- CMakeFiles/netconf2.dir/src/session_client.c.o ---
*** [CMakeFiles/netconf2.dir/src/session_client.c.o] Error code 1

make[2]: stopped in /home/sq/libnetconf2/build
8 errors

make[2]: stopped in /home/sq/libnetconf2/build
--- CMakeFiles/netconf2.dir/all ---
*** [CMakeFiles/netconf2.dir/all] Error code 2

make[1]: stopped in /home/sq/libnetconf2/build
1 error

make[1]: stopped in /home/sq/libnetconf2/build
*** [all] Error code 2

make: stopped in /home/sq/libnetconf2/build
1 error

make: stopped in /home/sq/libnetconf2/build

that seems to be an issue with this:

#ifndef HAVE_CRYPT_R

/* unused anyway */
struct crypt_data {
    char a;
};

char *crypt_r(const char *phrase, const char *setting, struct crypt_data *data);
#endif

[michalvasko]

Please slow down a bit if you want me to help you, the problems need to be solved one-by-one.

[paigeadelethompson]

no worries I'm already on the third problem, the solution seems to be to get rid of the first two, I've made a little more progress, now I'm looking at an issue with:

/home/sq/libnetconf2/src/server_config_util_ssh.c:20:10: fatal error: 'crypt.h' file not found
   20 | #include <crypt.h>
      |          ^~~~~~~~~

really the tldr seems nobody has built this in awhile or at least not on freebsd... yeah theres no global include for crypt.h though xD

/usr/include/rpcsvc/crypt.h
/usr/src/lib/libcrypt/crypt.h
/usr/obj/usr/src/arm64.aarch64/include/rpcsvc/crypt.h
/usr/obj/usr/src/arm64.aarch64/tmp/usr/include/rpcsvc/crypt.h
/usr/obj/usr/src/arm64.aarch64/lib/libc/crypt.h
/usr/local/include/postgresql/server/libpq/crypt.h
/usr/local/include/minizip/crypt.h

[michalvasko]

I do remember someone fixing compatibility with freeBSD but I guess it was some time ago and maybe only libyang, not libnetconf2. So I will install a VM and fix everything I come across, this header is meant to solve all such compatibility issues.

[paigeadelethompson]

cool thanks man :) I'll check in here in a bit

[michalvasko]

I have committed the fixes for libyang and libnetconf2, not sure if you want to also compile sysrepo or netopeer2.

[paigeadelethompson]

Awesome I will check it out here in a few, I've actually not heard of those two until now. Sysrepo actually does sound potentially relevant though I was planning to write something that does that anyway. I want to make something that provides a netconf cli for configuring interfaces / routes / arp / ndp for FreeBSD, and its also going to have it's own persistence (most of my network configuration needs quickly outgrow rc.conf.)

I've e-mailed somebody who's pretty near to FreeBSD about whether or not I could contribute something like that to the core operating system; I think in that case they would want to include copies of both libraries in-tree, in /usr/src/contrib, and I'm trying to figure out if that will work for FreeBSD but failing that, would this work for you?

I think for sysrepo and netopeer2 I'm going to stick to the original scope for now but if this is less problematic for them than I'm imagining I might revisit that.

[paigeadelethompson]

I have committed the fixes for libyang and libnetconf2, not sure if you want to also compile sysrepo or netopeer2.

update I just tested it and it builds / works great thank you!

[michalvasko]

would this work for you?

The BSD-3-Clause license is very permissive so this is not a problem, we would actually appreciate that. The more systems come with our libraries/packages of them, the better.

[paigeadelethompson]

yeah it'll be cool if we can pull it off, the only issue I can see might be the dependency or pcre or xxhash, otherwise I was able to vendor both libyang and libnetconf2 without making any modifications to their src tree. https://github.com/Ravenhammer-Research/netd I also managed to pull off embedding the yang schemas and I just got that working. It's taken me a while to figure out how this library was meant to be used suffice to say I think you really have to use every part of it (including the store pattern) before it will even start to make any sense. I'm starting to create test cases now, though in ATF and kyua which is kind of common for anything in freebsd-src. You'll have to forgive my ignorance though I'm sorta figuring this out as I go along and ultimately it's the value that it has to me that is motivation for the work but I figure if I can just get it to a point where it does something again, I'll be a lot more open to suggestions. At various points though I've covered a lot of yang (networking-instance, bind-ni-name, augments, etc) and ofc ietf indicated schemas but ultimately I'm trying my best to aim for something that will at least speak to other devices in some capacity while still having the ability to be more configurable than what compatibility alone will allow and I think I've finally got it figured out;

gotta say not bad-- I've messed with some really cracked out XML stuff before like WCF (which I'd probably still like but it feels ruined and esoteric at this point.) This is not bad though. The only thing that really bothered me about it was just having external schemas which isn't a terrible thing I just prefer not to if I can avoid it and it seems I found a way that works:

https://github.com/Ravenhammer-Research/netd/blob/master/cmake/EmbeddedYang.cmake
https://github.com/Ravenhammer-Research/netd/blob/master/src/server/netconf/yang.c#L57
https://github.com/Ravenhammer-Research/netd/blob/master/test/server/netconf/test_yang.c#L74

Edit:

my guess is they would wanna see it use this https://man.freebsd.org/cgi/man.cgi?query=regex

xxhash could perhaps be vendored: https://github.com/Cyan4973/xxHash (there's quite a few things which use it in freebsd-src but as near as I can tell there's no one xxhash lib)