common BUGFIX avoid overflow

michalvasko · michalvasko · commit 014507d4f0f8 · 2024-06-26T16:02:44.000+02:00
... even though it's harmless.
diff --git a/src/ly_common.c b/src/ly_common.c
@@ -74,7 +74,8 @@ ly_strncmp(const char *refstr, const char *str, size_t str_len)
 LY_ERR
 ly_strntou8(const char *nptr, size_t len, uint8_t *ret)
 {
-    uint8_t num = 0, dig, dec_pow;
+    uint8_t num = 0, dig;
+    uint16_t dec_pow;
 
     if (len > 3) {
         /* overflow for sure */

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,8 @@ ly_strncmp(const char refstr, const char str, size_t str_len)`
`74`	`74`	`LY_ERR`
`75`	`75`	`ly_strntou8(const char nptr, size_t len, uint8_t ret)`
`76`	`76`	`{`
`77`		`- uint8_t num = 0, dig, dec_pow;`
	`77`	`+ uint8_t num = 0, dig;`
	`78`	`+ uint16_t dec_pow;`
`78`	`79`
`79`	`80`	`if (len > 3) {`
`80`	`81`	`/* overflow for sure */`