plugins ext UPDATE remove the need for SM context destroy

Author: michalvasko

src/plugins_exts.c

@@ -761,8 +761,14 @@ lyplg_ext_set_parent_ctx(struct ly_ctx *ctx, const struct ly_ctx *parent_ctx)
     } while (c);
 
     if (!ctx->parent_ctx) {
-        /* remove its shared and private data */
-        ly_ctx_data_del(ctx);
+        if (ly_ctx_is_printed(ctx) && ly_ctx_is_printed(parent_ctx)) {
+            /* completely destroy the printed context, assume it will not be destroyed (in case of schema-mount
+             * contexts, there is no ext callback for freeing the compiled extension data with the contexts) */
+            ly_ctx_destroy(ctx);
+        } else {
+            /* remove its shared and private data */
+            ly_ctx_data_del(ctx);
+        }
     } else if (!parent_ctx) {
         /* create its shared and private data */
         LY_CHECK_RET(ly_ctx_data_add(ctx));

src/plugins_exts/schema_mount.c

@@ -533,43 +533,37 @@ lyplg_ext_schema_mount_destroy_shared_contexts(struct lysc_ext_instance *ext)
     int r;
     uint32_t i;
     struct lyplg_ext_sm *sm_data;
-    ly_bool ctx_is_printed;
 
     LY_CHECK_ARG_RET(NULL, ext, );
 
+    if (ly_ctx_is_printed(ext->module->ctx)) {
+        /* shared contexts were destroyed during ext compilation */
+        return;
+    }
+
     sm_data = ext->compiled;
-    ctx_is_printed = ly_ctx_is_printed(ext->module->ctx);
 
-    /* LOCK (dont lock if pctx since its memory is not writable) */
-    if (!ctx_is_printed) {
-        if ((r = pthread_mutex_lock(&sm_data->lock))) {
-            lyplg_ext_compile_log(NULL, ext, LY_LLERR, LY_ESYS, "Mutex lock failed (%s).", strerror(r));
-            return;
-        }
+    /* LOCK */
+    if ((r = pthread_mutex_lock(&sm_data->lock))) {
+        lyplg_ext_compile_log(NULL, ext, LY_LLERR, LY_ESYS, "Mutex lock failed (%s).", strerror(r));
+        return;
     }
 
     /* free all the shared schemas of this ext */
     for (i = 0; i < sm_data->shared->schema_count; ++i) {
-        /* ctx can be destroyed whether printed or not */
         ly_ctx_destroy(sm_data->shared->schemas[i].ctx);
-
-        if (!ctx_is_printed) {
-            /* these members can be freed only if the context is not printed */
-            free(sm_data->shared->schemas[i].mount_point);
-            sm_data->shared->schemas[i].mount_point = NULL;
-            free(sm_data->shared->schemas[i].content_id);
-            sm_data->shared->schemas[i].content_id = NULL;
-        }
+        free(sm_data->shared->schemas[i].mount_point);
+        sm_data->shared->schemas[i].mount_point = NULL;
+        free(sm_data->shared->schemas[i].content_id);
+        sm_data->shared->schemas[i].content_id = NULL;
     }
 
-    if (!ctx_is_printed) {
-        free(sm_data->shared->schemas);
-        sm_data->shared->schemas = NULL;
-        sm_data->shared->schema_count = 0;
+    free(sm_data->shared->schemas);
+    sm_data->shared->schemas = NULL;
+    sm_data->shared->schema_count = 0;
 
-        /* UNLOCK */
-        pthread_mutex_unlock(&sm_data->lock);
-    }
+    /* UNLOCK */
+    pthread_mutex_unlock(&sm_data->lock);
 }
 
 LIBYANG_API_DEF void