xpath BUGFIX special * path is not limited to context module

Author: michalvasko

src/xpath.c

@@ -5167,12 +5167,11 @@ moveto_node_add(struct lyxp_set *set, struct lyd_node *node, uint32_t pos, uint3
  * @param[in] qname Qualified node name to move to.
  * @param[in] qname_len Length of \p qname.
  * @param[in] options Whether to apply data node access restrictions defined for 'when' and 'must' evaluation.
- * @param[in] all_ns Flag simulating an expression in the form "*:qname", which is not a valid XPath.
  *
  * @return EXIT_SUCCESS on success, EXIT_FAILURE on unresolved when, -1 on error.
  */
 static int
-moveto_node(struct lyxp_set *set, struct lyd_node *cur_node, const char *qname, uint16_t qname_len, int options, int all_ns)
+moveto_node(struct lyxp_set *set, struct lyd_node *cur_node, const char *qname, uint16_t qname_len, int options)
 {
     uint32_t i;
     int replaced, pref_len, ret;
@@ -5198,6 +5197,7 @@ moveto_node(struct lyxp_set *set, struct lyd_node *cur_node, const char *qname,
 
     /* prefix */
     if ((ptr = strnchr(qname, ':', qname_len))) {
+        /* specific module */
         pref_len = ptr - qname;
         moveto_mod = moveto_resolve_model(qname, pref_len, ctx, NULL, 1);
         if (!moveto_mod) {
@@ -5206,7 +5206,11 @@ moveto_node(struct lyxp_set *set, struct lyd_node *cur_node, const char *qname,
         }
         qname += pref_len + 1;
         qname_len -= pref_len + 1;
+    } else if ((qname[0] == '*') && (qname_len == 1)) {
+        /* all modules - special case */
+        moveto_mod = NULL;
     } else {
+        /* content node module */
         moveto_mod = lyd_node_module(cur_node);
     }
 
@@ -5218,7 +5222,7 @@ moveto_node(struct lyxp_set *set, struct lyd_node *cur_node, const char *qname,
 
         if ((set->val.nodes[i].type == LYXP_NODE_ROOT_CONFIG) || (set->val.nodes[i].type == LYXP_NODE_ROOT)) {
             LY_TREE_FOR(set->val.nodes[i].node, sub) {
-                ret = moveto_node_check(sub, root_type, name_dict, all_ns ? NULL : moveto_mod, options);
+                ret = moveto_node_check(sub, root_type, name_dict, moveto_mod, options);
                 if (!ret) {
                     /* pos filled later */
                     moveto_node_add(set, sub, 0, i, &replaced);
@@ -5234,7 +5238,7 @@ moveto_node(struct lyxp_set *set, struct lyd_node *cur_node, const char *qname,
                 && !(set->val.nodes[i].node->schema->nodetype & (LYS_LEAF | LYS_LEAFLIST | LYS_ANYDATA))) {
 
             LY_TREE_FOR(set->val.nodes[i].node->child, sub) {
-                ret = moveto_node_check(sub, root_type, name_dict, all_ns ? NULL : moveto_mod, options);
+                ret = moveto_node_check(sub, root_type, name_dict, moveto_mod, options);
                 if (!ret) {
                     moveto_node_add(set, sub, 0, i, &replaced);
                     ++i;
@@ -5414,8 +5418,8 @@ moveto_node_alldesc(struct lyxp_set *set, struct lyd_node *cur_node, const char
         moveto_mod = NULL;
     }
 
-    /* special path, replace the original nodes (and throws away all text and attr nodes, root is replaced by a child) */
-    ret = moveto_node(set, cur_node, "*", 1, options, 1);
+    /* replace the original nodes (and throws away all text and attr nodes, root is replaced by a child) */
+    ret = moveto_node(set, cur_node, "*", 1, options);
     if (ret) {
         return ret;
     }
@@ -6528,7 +6532,7 @@ eval_node_test(struct lyxp_expr *exp, uint16_t *exp_idx, struct lyd_node *cur_no
                                       exp->tok_len[*exp_idx], options);
                 } else {
                     rc = moveto_node(set, cur_node, &exp->expr[exp->expr_pos[*exp_idx]], exp->tok_len[*exp_idx],
-                                     options, 0);
+                                     options);
                 }
             }