common BUGFIX prevent double free

michalvasko · michalvasko · commit ccec3f4b8677 · 2025-11-04T09:41:17.000+01:00
Fixes #2450
diff --git a/src/ly_common.c b/src/ly_common.c
@@ -631,8 +631,11 @@ ly_realloc(void *ptr, size_t size)
 {
     void *new_mem;
 
+    /* may cause double-free if NULL is returned */
+    assert(size);
+
     new_mem = realloc(ptr, size);
-    if (!new_mem) {
+    if (!new_mem && size) {
         free(ptr);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -631,8 +631,11 @@ ly_realloc(void *ptr, size_t size)`
`631`	`631`	`{`
`632`	`632`	`void *new_mem;`
`633`	`633`
	`634`	`+ /* may cause double-free if NULL is returned */`
	`635`	`+ assert(size);`
	`636`	`+`
`634`	`637`	`new_mem = realloc(ptr, size);`
`635`		`- if (!new_mem) {`
	`638`	`+ if (!new_mem && size) {`
`636`	`639`	`free(ptr);`
`637`	`640`	`}`
`638`	`641`