tree schema BUGFIX avoid creating contexts that need to be freed

Author: michalvasko

src/ly_common.h

@@ -4,7 +4,7 @@
  * @author Michal Vasko <[email protected]>
  * @brief common internal definitions for libyang
  *
- * Copyright (c) 2015 - 2024 CESNET, z.s.p.o.
+ * Copyright (c) 2015 - 2025 CESNET, z.s.p.o.
  *
  * This source code is licensed under BSD 3-Clause License (the "License").
  * You may not use this file except in compliance with the License.
@@ -680,4 +680,13 @@ LY_ERR ly_munmap(void *addr, size_t length);
  */
 LY_ERR ly_strcat(char **dest, const char *format, ...) _FORMAT_PRINTF(2, 3);
 
+/**
+ * @brief Get schema (context) for a mount point.
+ *
+ * @param[in] ext Compiled extension instance where the context is also stored.
+ * @param[out] ext_ctx Schema to use for parsing the data.
+ * @return LY_ERR value.
+ */
+LY_ERR lyplg_ext_schema_mount_get_ctx(struct lysc_ext_instance *ext, const struct ly_ctx **ext_ctx);
+
 #endif /* LY_COMMON_H_ */

src/plugins_exts/schema_mount.c

@@ -624,15 +624,8 @@ schema_mount_get_ctx_inline(struct lysc_ext_instance *ext, const struct lyd_node
     return rc;
 }
 
-/**
- * @brief Get schema (context) for a mount point.
- *
- * @param[in] ext Compiled extension instance.
- * @param[out] ext_ctx Schema to use for parsing the data.
- * @return LY_ERR value.
- */
-static LY_ERR
-schema_mount_get_ctx(struct lysc_ext_instance *ext, const struct ly_ctx **ext_ctx)
+LY_ERR
+lyplg_ext_schema_mount_get_ctx(struct lysc_ext_instance *ext, const struct ly_ctx **ext_ctx)
 {
     LY_ERR ret = LY_SUCCESS, r;
     struct lyd_node *iter, *ext_data = NULL;
@@ -693,7 +686,7 @@ schema_mount_snode(struct lysc_ext_instance *ext, const struct lyd_node *parent,
     const struct ly_ctx *ext_ctx = NULL;
 
     /* get context based on ietf-yang-library data */
-    if ((r = schema_mount_get_ctx(ext, &ext_ctx))) {
+    if ((r = lyplg_ext_schema_mount_get_ctx(ext, &ext_ctx))) {
         return r;
     }
 

src/tree_schema.c

@@ -168,7 +168,7 @@ lys_getnext_(const struct lysc_node *last, const struct lysc_node *parent, const
     const struct lysc_node *next = NULL;
     ly_bool action_flag = 0, notif_flag = 0, sm_flag = options & LYS_GETNEXT_WITHSCHEMAMOUNT ? 0 : 1;
     LY_ARRAY_COUNT_TYPE u;
-    struct ly_ctx *sm_ctx = NULL;
+    const struct ly_ctx *sm_ctx = NULL;
     const struct lys_module *mod;
     uint32_t idx;
 
@@ -259,7 +259,7 @@ lys_getnext_(const struct lysc_node *last, const struct lysc_node *parent, const
                 LY_ARRAY_FOR(parent->exts, u) {
                     if (!strcmp(parent->exts[u].def->name, "mount-point") &&
                             !strcmp(parent->exts[u].def->module->name, "ietf-yang-schema-mount")) {
-                        lyplg_ext_schema_mount_create_context(&parent->exts[u], &sm_ctx);
+                        lyplg_ext_schema_mount_get_ctx(&parent->exts[u], &sm_ctx);
                         if (sm_ctx) {
                             /* some usable context created */
                             break;
@@ -276,10 +276,6 @@ lys_getnext_(const struct lysc_node *last, const struct lysc_node *parent, const
 
                         next = lys_getnext(NULL, NULL, mod->compiled, options & ~LYS_GETNEXT_WITHSCHEMAMOUNT);
                     }
-                    if (!next) {
-                        /* no nodes found */
-                        ly_ctx_destroy(sm_ctx);
-                    }
                 }
             }
         } else {