fix: 🐛 Fix reading configurati novalues in ExtractRequestAttrib

Author: Dominik Frantisek Bucik

config-templates/processFilterConfigurations-example.md

@@ -166,7 +166,7 @@ Example how to enable filter AttributeMap:
 Filter is intended to extract an attribute specified by set of keys forming the chain of keys in the `$request` variable into the configured destination attribute.
 
 Configuration options:
-* `attr_name`: specifies attribute name, into which the extracted value will be stored
+* `destination_attr_name`: specifies attribute name, into which the extracted value will be stored
 * `request_keys`: string, which contains a semicolon (`;`) separated chain of keys that are examined in the state. Numeric keys are automatically treated as array indexes. For instance, value `'saml:AuthenticatingAuthority;0'` will be treated as code `$request['saml:AuthenticatingAuthority'][0]`. In case of this value being empty, exception is thrown. Otherwise, extracted value is stored into the configured destination attribute.
 * `fail_on_nonexisting_keys`: `true` or `false`, specifies if in case of missing key in the request variable the filter should terminate with an exception or not
 * `default_value`: array, which will be set as default value, if the configured keys did not lead to value
@@ -175,10 +175,10 @@ Configuration options:
 // EXTRACT AUTHENTICATING ENTITY INTO authenticating_idp attribute
 1 => [ 
     'class' => 'perun:ExtractRequestAttribute',
-    'attr_name' => 'authenticating_idp',
+    'destination_attr_name' => 'authenticating_idp',
     'request_keys' => 'saml:AuthenticatingAuthority;0',
     'fail_on_nonexisting_keys' => 'true',
-    'default_value' => null,
+    'default_value' => [],
 ],
 ```
 

lib/Auth/Process/ExtractRequestAttribute.php

@@ -24,7 +24,7 @@ class ExtractRequestAttribute extends ProcessingFilter
     public const DEFAULT_VALUE = 'default_value';
 
     public const KEYS_SEPARATOR = ';';
-    public const FAILURE_VALUE = '%$FAILURE_VALUE$%';
+    public const FAILURE_VALUE = ['%$FAILURE_VALUE$%'];
 
     private $destinationAttrName;
     private $requestKeys;
@@ -38,7 +38,7 @@ public function __construct($config, $reserved)
         $this->filterConfig = Configuration::loadFromArray($config);
 
         $this->destinationAttrName = $this->filterConfig->getString(self::DESTINATION_ATTRIBUTE_NAME, null);
-        if (empty($this->requestKeys)) {
+        if (empty($this->destinationAttrName)) {
             throw new Exception(
                 self::DEBUG_PREFIX . 'missing mandatory configuration for option \'' . self::DESTINATION_ATTRIBUTE_NAME . '\''
             );
@@ -75,9 +75,7 @@ public function process(&$request)
             }
             if (!array_key_exists($key, $value)) {
                 Logger::warning(
-                    self::DEBUG_PREFIX . 'Cannot find key \'' .
-                    $key . '\' in the supposed path towards the value. Did you configure the right path of keys ' .
-                    'to extract it?'
+                    self::DEBUG_PREFIX . 'Cannot find key \'' . $key . '\' in the supposed path towards the value. Did you configure the right path of keys to extract it?'
                 );
                 if ($this->failOnNonExistingKey) {
                     throw new Exception(self::DEBUG_PREFIX . 'Specified chain of keys does not exist');
@@ -99,9 +97,9 @@ public function process(&$request)
             $value = [$value];
         }
         $request[PerunConstants::ATTRIBUTES][$this->destinationAttrName] = $value;
+        $logValue = implode(',', $value);
         Logger::debug(
-            self::DEBUG_PREFIX . 'Value \'' . implode(',', $value)
-            . '\' has been extracted and set to attribute ' . $this->destinationAttrName
+            self::DEBUG_PREFIX . 'Value \'' . $logValue . '\' has been extracted and set to attribute ' . $this->destinationAttrName
         );
     }
 }