refactor: do not assign in if statement

melanger · web-flow · commit 661f8ffaef01 · 2021-09-01T11:38:44.000+02:00
diff --git a/lib/NagiosStatusConnector.php b/lib/NagiosStatusConnector.php
@@ -63,7 +63,8 @@ public function getStatus()
     {
         $result = [];
 
-        if (! ($key = file_get_contents($this->keyPath))) {
+        $key = file_get_contents($this->keyPath);
+        if (! $key) {
             throw new Exception('Cannot load ket from path:  \'' . $this->keyPath . '\' !');
         }
 

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,8 @@ public function getStatus()`
`63`	`63`	`{`
`64`	`64`	`$result = [];`
`65`	`65`
`66`		`- if (! ($key = file_get_contents($this->keyPath))) {`
	`66`	`+ $key = file_get_contents($this->keyPath);`
	`67`	`+ if (! $key) {`
`67`	`68`	`throw new Exception('Cannot load ket from path: \'' . $this->keyPath . '\' !');`
`68`	`69`	`}`
`69`	`70`