Fixed the bug from commit bc3ec33 which caused that the updating UES didn't work.

* Problem was caused by rewriting the value of property 'attributes' in the middle of a function, so there weren't any attributes to update.

Author: vyskocilpavel

CHANGELOG.md

@@ -2,6 +2,10 @@
 All notable changes to this project will be documented in this file.
 
 ## [Unreleased]
+#### Fixed
+- Fixed the bug from [bc3ec33] which caused that the updating UES didn't work.
+
+[bc3ec33]:https://github.com/CESNET/perun-simplesamlphp-module/commit/bc3ec33c8f5088f7be712b8e5a0e70f229731648
 
 ## [v3.7.2]
 #### Fixed

www/updateUes.php

@@ -14,7 +14,7 @@
 $entityBody = file_get_contents('php://input');
 $body = json_decode($entityBody, true);
 
-$attributes = $body['attributes'];
+$attributesFromIdP = $body['attributes'];
 $attrMap = $body['attrMap'];
 $attrsToConversion = $body['attrsToConversion'];
 $perunUserId = $body['perunUserId'];
@@ -23,30 +23,37 @@
 
 try {
     $userExtSource = $adapter->getUserExtSource(
-        $attributes['sourceIdPEntityID'][0],
-        $attributes['sourceIdPEppn'][0]
+        $attributesFromIdP['sourceIdPEntityID'][0],
+        $attributesFromIdP['sourceIdPEppn'][0]
     );
     if ($userExtSource === null) {
         throw new Exception(
             'sspmod_perun_Auth_Process_UpdateUserExtSource: there is no UserExtSource with ExtSource ' .
-            $attributes['sourceIdPEntityID'][0] . " and Login " .
-            $attributes['sourceIdPEppn'][0]
+            $attributesFromIdP['sourceIdPEntityID'][0] . " and Login " .
+            $attributesFromIdP['sourceIdPEppn'][0]
         );
     }
 
-    $attributes = $adapter->getUserExtSourceAttributes($userExtSource['id'], array_keys($attrMap));
+    $attributesFromPerunRaw = $adapter->getUserExtSourceAttributes($userExtSource['id'], array_keys($attrMap));
+    $attributesFromPerun = [];
+    foreach ($attributesFromPerunRaw as $attributeFromPerunRaw) {
+        $attributesFromPerun[$attributeFromPerunRaw['friendlyName']] = $attributeFromPerunRaw;
+    }
 
-    if ($attributes === null) {
+    if ($attributesFromPerun === null) {
         throw new Exception(
             'sspmod_perun_Auth_Process_UpdateUserExtSource: getting attributes was not successful.'
         );
     }
 
     $attributesToUpdate = [];
-    foreach ($attributes as $attribute) {
+
+    foreach ($attributesFromPerun as $attribute) {
+
         $attrName = UES_ATTR_NMS . $attribute['friendlyName'];
-        if (isset($attrMap[$attrName], $attributes[$attrMap[$attrName]])) {
-            $attr = $attributes[$attrMap[$attrName]];
+
+        if (isset($attrMap[$attrName], $attributesFromIdP[$attrMap[$attrName]])) {
+            $attr = $attributesFromIdP[$attrMap[$attrName]];
 
             if (in_array(UES_ATTR_NMS . $attribute['friendlyName'], $attrsToConversion)) {
                 $arrayAsString = [''];