Skip to content
This repository was archived by the owner on Sep 19, 2022. It is now read-only.

Commit 9ecf4c0

Browse files
committed
fix: Fixed AUP filter
1 parent e62c65b commit 9ecf4c0

File tree

1 file changed

+11
-5
lines changed

1 file changed

+11
-5
lines changed

lib/Auth/Process/ForceAup.php

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,13 @@ public function process(&$request)
157157
$perunAups = $this->getPerunAups();
158158
$voAups = $this->getVoAups($voShortNames);
159159

160-
$aupsToBeApproved = $this->getAupsToBeApproved($perunAups, $voAups, $requestedAups, $userAups);
160+
$aupsToBeApproved = $this->getAupsToBeApproved(
161+
$perunAups,
162+
$voAups,
163+
$voShortNames,
164+
$requestedAups,
165+
$userAups
166+
);
161167
} catch (\Exception $ex) {
162168
Logger::warning('perun:ForceAup - ' . $ex->getMessage());
163169
$aupsToBeApproved = [];
@@ -240,7 +246,7 @@ private function getPerunAups()
240246
return $perunAups;
241247
}
242248

243-
private function getAupsToBeApproved($perunAups, $voAups, $requestedAups, $userAups)
249+
private function getAupsToBeApproved($perunAups, $voAups, $voShortNames, $requestedAups, $userAups)
244250
{
245251
$perunAupsToBeApproved = [];
246252
if (!empty($perunAups)) {
@@ -249,7 +255,7 @@ private function getAupsToBeApproved($perunAups, $voAups, $requestedAups, $userA
249255

250256
$voAupsToBeApproved = [];
251257
if (!empty($voAups)) {
252-
$voAupsToBeApproved = $this->fillAupsToBeApproved($requestedAups, $voAups, $userAups);
258+
$voAupsToBeApproved = $this->fillAupsToBeApproved($voShortNames, $voAups, $userAups);
253259
}
254260

255261
return $this->mergeAupsToBeApproved($perunAupsToBeApproved, $voAupsToBeApproved);
@@ -294,9 +300,9 @@ private function mergeAupsToBeApproved(array $perunAupsToBeApproved, array $voAu
294300
$voLatestDate = self::parseDateTime($voAup->date);
295301
$perunLatestDate = self::parseDateTime($perunAupsToBeApproved[$aupKey]->date);
296302
if ($voLatestDate >= $perunLatestDate) {
297-
$resultAups[$aupKey] = $voLatestDate;
303+
$resultAups[$aupKey] = $voAup;
298304
} else {
299-
$resultAups[$aupKey] = $perunLatestDate;
305+
$resultAups[$aupKey] = $perunAupsToBeApproved[$aupKey];
300306
}
301307
} else {
302308
$resultAups[$aupKey] = $voAup;

0 commit comments

Comments
 (0)