fix(admin): bulk application approve/reject error handling

* An error during bulk approval or reject now creates a new notification and immediately opens its dialog to provide feedback

Author: michalberky

apps/admin-gui/src/app/shared/components/application-actions/application-actions.component.ts

@@ -16,6 +16,8 @@ import { NotificatorService, PerunTranslateService } from '@perun-web-apps/perun
 import { MatDialog, MatDialogRef } from '@angular/material/dialog';
 import { ApplicationsBulkOperationDialogComponent } from '../dialogs/applications-bulk-operation-dialog/applications-bulk-operation-dialog.component';
 import { getDefaultDialogConfig } from '@perun-web-apps/perun/utils';
+import { NotificationData, RPCError } from '@perun-web-apps/perun/models';
+import { NotificationDialogComponent } from '@perun-web-apps/perun/dialogs';
 
 export interface AppAction {
   approve: boolean;
@@ -155,6 +157,16 @@ export class ApplicationActionsComponent implements OnInit {
               this.notificator.showInstantSuccess('VO_DETAIL.APPLICATION.SUCCESS.APPROVE');
               this.refreshTable();
             },
+            error: (error: RPCError) => {
+              this.showErrorDialog(
+                'VO_DETAIL.APPLICATION.ERROR.APPROVE',
+                error,
+                this.translate.instant('VO_DETAIL.APPLICATION.ERROR.APPROVE_DESCRIPTION', {
+                  error: error.message,
+                }),
+              );
+              this.refreshTable();
+            },
           });
       }
     });
@@ -178,6 +190,16 @@ export class ApplicationActionsComponent implements OnInit {
               this.notificator.showInstantSuccess('VO_DETAIL.APPLICATION.SUCCESS.REJECT');
               this.refreshTable();
             },
+            error: (error: RPCError) => {
+              this.showErrorDialog(
+                'VO_DETAIL.APPLICATION.ERROR.REJECT',
+                error,
+                this.translate.instant('VO_DETAIL.APPLICATION.ERROR.REJECT_DESCRIPTION', {
+                  error: error.message,
+                }),
+              );
+              this.refreshTable();
+            },
           });
       }
     });
@@ -373,4 +395,37 @@ export class ApplicationActionsComponent implements OnInit {
     newDate.setDate(newDate.getDate() - 365);
     return newDate;
   }
+
+  // FIXME: showErrorDialog() and createNotificationData() are part of a quickfix and to be remove after proper fix is made
+  private showErrorDialog(title: string, error: RPCError, description: string): void {
+    const notificationData: NotificationData = this.createNotificationData(
+      title,
+      error,
+      description,
+    );
+    this.dialog.open(NotificationDialogComponent, {
+      width: '550px',
+      data: notificationData,
+      autoFocus: false,
+    });
+  }
+
+  private createNotificationData(
+    title: string,
+    error?: RPCError,
+    description?: string,
+  ): NotificationData {
+    const notificationData: NotificationData = {
+      type: 'error',
+      error: error,
+      description: description,
+      title: this.translate.instant(title),
+      actionText: this.notificator.getDefaultActionMessage(),
+      delay: this.notificator.defaultErrorDelayMs,
+      icon: 'error_outline',
+      action: null,
+      timeStamp: `${new Date().getHours()}:${new Date().getMinutes()}`,
+    };
+    return notificationData;
+  }
 }

apps/admin-gui/src/assets/i18n/en.json

@@ -674,6 +674,12 @@
         "DELETE": "Applications were successfully deleted.",
         "RESEND": "Notifications for applications were re-sent."
       },
+      "ERROR": {
+        "APPROVE": "Failed to approve some applications.",
+        "APPROVE_DESCRIPTION": "A problem occurred during approval: [{{error}}] and not all of the selected applications got approved. There may still be some of the selected applications that could possibly be approved.",
+        "REJECT": "Failed to reject some applications.",
+        "REJECT_DESCRIPTION": "A problem occurred during rejection: [{{error}}] and not all of the selected applications got rejected. There may still be some of the selected applications that could possibly be rejected."
+      },
 
       "APPLICATION_DETAIL": {
         "TITLE": "Application detail",