Skip to content

Commit 12b5218

Browse files
committed
Merge branch 'master' into production
2 parents df0c1df + 2f9b26f commit 12b5218

File tree

14 files changed

+45
-45
lines changed

14 files changed

+45
-45
lines changed

perun-wui-consolidator/src/main/webapp/PerunConsolidatorCESNET.html

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

perun-wui-consolidator/src/main/webapp/PerunConsolidatorEINFRA.html

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

perun-wui-profile/src/main/java/cz/metacentrum/perun/wui/profile/client/resources/PerunProfileTranslation.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -391,7 +391,7 @@ public interface PerunProfileTranslation extends PerunTranslation {
391391
@DefaultMessage("Examples of password descriptions: “email on mobile phone” or “teleconferences on tablet”.")
392392
String alternativePasswordsExample();
393393

394-
@DefaultMessage("Copy to clipbord")
394+
@DefaultMessage("Copy to clipboard")
395395
String copyPassword();
396396

397397
@DefaultMessage("Close")

perun-wui-profile/src/main/java/cz/metacentrum/perun/wui/profile/pages/resources/ResourcesPresenter.java

Lines changed: 24 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package cz.metacentrum.perun.wui.profile.pages.resources;
22

3-
4-
import com.google.gwt.core.client.GWT;
53
import com.google.gwt.core.client.JavaScriptObject;
64
import com.google.inject.Inject;
75
import com.google.web.bindery.event.shared.EventBus;
@@ -24,7 +22,6 @@
2422
import cz.metacentrum.perun.wui.model.PerunException;
2523
import cz.metacentrum.perun.wui.model.beans.Group;
2624
import cz.metacentrum.perun.wui.model.beans.Member;
27-
import cz.metacentrum.perun.wui.model.beans.Resource;
2825
import cz.metacentrum.perun.wui.model.beans.RichResource;
2926
import cz.metacentrum.perun.wui.model.beans.Vo;
3027
import cz.metacentrum.perun.wui.profile.client.PerunProfileUtils;
@@ -129,7 +126,7 @@ private void loadMemberAndResources(Integer userId, int voId) {
129126
@Override
130127
public void onFinished(JavaScriptObject result) {
131128
Member member = (Member) result;
132-
loadResources(member.getId());
129+
loadResources(member);
133130
}
134131

135132
@Override
@@ -144,15 +141,15 @@ public void onLoadingStart() {
144141
});
145142
}
146143

147-
private void loadResources(int id) {
148-
ResourcesManager.getAssignedRichResources(id, new JsonEvents() {
144+
private void loadResources(Member member) {
145+
ResourcesManager.getAssignedRichResources(member.getId(), new JsonEvents() {
149146
@Override
150147
public void onFinished(JavaScriptObject result) {
151148
List<RichResource> resources = JsUtils.jsoAsList(result);
152149
if (resources.isEmpty()) {
153150
getView().setResources(new HashMap<>());
154151
} else {
155-
loadGroupsForResources(resources);
152+
loadGroupsForResources(member, resources);
156153
}
157154
}
158155

@@ -168,44 +165,28 @@ public void onLoadingStart() {
168165
});
169166
}
170167

171-
private void loadGroupsForResources(List<RichResource> richResources) {
168+
private void loadGroupsForResources(Member member, List<RichResource> richResources) {
172169
final Integer userId = PerunProfileUtils.getUserId(placeManager);
173170

174171
final PlaceRequest request = placeManager.getCurrentPlaceRequest();
175172

176173
if (userId == null) {
177174
placeManager.revealErrorPlace(request.getNameToken());
178175
} else {
179-
180-
AbstractRepeatingJsonEvent memberEvent = new AbstractRepeatingJsonEvent(richResources.size()) {
181-
@Override
182-
public void done(List<JavaScriptObject> results) {
183-
List<Member> members = JsUtils.jsListAsList(results);
184-
loadGroupsFromMembers(richResources, members);
185-
}
186-
187-
@Override
188-
public void erred(PerunException exception) {
189-
getView().setResourcesDataError(exception);
190-
}
191-
192-
@Override
193-
public void started() {
194-
// do nothing
195-
}
196-
};
197-
198-
for (RichResource resource : richResources) {
199-
MembersManager.getMemberByUser(userId, resource.getVoId(), memberEvent);
200-
}
176+
loadGroupsFromMember(richResources, member);
201177
}
202178
}
203179

204-
private void loadGroupsFromMembers(List<RichResource> resources, List<Member> members) {
180+
private void loadGroupsFromMember(List<RichResource> resources, Member member) {
181+
182+
AbstractRepeatingJsonEvent event = new AbstractRepeatingJsonEvent(resources.size()) {
205183

206-
AbstractRepeatingJsonEvent resourceGroupsEvent = new AbstractRepeatingJsonEvent(members.size()) {
207184
@Override
208185
public void done(List<JavaScriptObject> results) {
186+
187+
// FIXME - this doesnt makes sense as AbstractRepeatingJsonEvent merges all results together
188+
// and we don't have list of "list", but just the list of all groups assigned to all resources
189+
// without any mapping (by id or other) between group and resource.
209190
List<List<Group>> resourcesGroups = new ArrayList<>();
210191

211192
for (JavaScriptObject result : results) {
@@ -232,11 +213,18 @@ public void started() {
232213
}
233214
};
234215

235-
for (int i = 0; i < members.size(); i++) {
236-
Member member = members.get(i);
237-
Resource resource = resources.get(i);
216+
/* FIXME - temporary disabled
217+
for (RichResource resource : resources) {
218+
ResourcesManager.getAssignedGroups(resource.getId(), member.getId(), event);
219+
}
220+
*/
238221

239-
ResourcesManager.getAssignedGroups(resource.getId(), member.getId(), resourceGroupsEvent);
222+
// pass with empty groups
223+
Map<RichResource, List<Group>> resourceWithGroups = new HashMap<>();
224+
for (RichResource resource : resources) {
225+
resourceWithGroups.put(resource,new ArrayList<Group>());
240226
}
227+
getView().setResources(resourceWithGroups);
228+
241229
}
242230
}

perun-wui-profile/src/main/webapp/PerunProfileCESNET.html

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

perun-wui-pwdreset/src/main/webapp/PerunPwdResetCESNET.html

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

perun-wui-pwdreset/src/main/webapp/PerunPwdResetEINFRA.html

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

perun-wui-registrar/src/main/java/cz/metacentrum/perun/wui/registrar/client/ExceptionResolverImpl.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -263,6 +263,8 @@ private void resolveCantBeSubmittedException() {
263263
setInfo(trans.cantSubmitLoA(), trans.notEligibleMETAIDP());
264264
} else if (Objects.equals("NOT_ELIGIBLE_EINFRAIDP", exception.getReason())) {
265265
setInfo(trans.cantSubmitLoA(), trans.notEligibleEINFRAIDP());
266+
} else if (Objects.equals("NEVER_EXPIRATION", exception.getReason())) {
267+
setInfo(trans.cantSubmitLoA(), trans.expirationNever());
266268
} else {
267269
setInfo(trans.cantSubmitLoA(), exception.getMessage());
268270
}

perun-wui-registrar/src/main/java/cz/metacentrum/perun/wui/registrar/client/resources/PerunRegistrarTranslation.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -417,6 +417,9 @@ public interface PerunRegistrarTranslation extends PerunTranslation {
417417
@DefaultMessage("<p>You are signed in with an e-INFRA CZ account. You <b>cannot register or renew your membership</b> using this identity.<p>Please <b>sign-out / close all browser windows</b> and sign-in again using an external identity provider - an account from your academic organization or a social identity provider if your institution doesn`t have one.")
418418
public String notEligibleEINFRAIDP();
419419

420+
@DefaultMessage("<p>You <b>cannot renew your membership</b> because it will never expire.")
421+
public String expirationNever();
422+
420423
@DefaultMessage("<p>Your application still awaits for mail address verification. If you continue now, it is most probable, that service will redirect you back to the registration form.<p>Please check your mailbox for verification mail. Once your application is verified and approved, you will be able to access the service.")
421424
public String redirectWaitForVerification();
422425

perun-wui-registrar/src/main/java/cz/metacentrum/perun/wui/registrar/pages/AppsView.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@ public void draw() {
104104
@Override
105105
public void onFinished(JavaScriptObject jso) {
106106
grid.setList(JsUtils.<Application>jsoAsList(jso));
107+
refresh.setEnabled(true);
107108
}
108109

109110
@Override
@@ -114,10 +115,12 @@ public void onClick(ClickEvent event) {
114115
RegistrarManager.getOpenApplicationsForUser(0, retry);
115116
}
116117
});
118+
refresh.setEnabled(true);
117119
}
118120

119121
@Override
120122
public void onLoadingStart() {
123+
refresh.setEnabled(false);
121124
grid.clearTable();
122125
grid.getLoaderWidget().onLoading(translation.loadingApplications());
123126
}
@@ -131,6 +134,7 @@ public void onLoadingStart() {
131134
@Override
132135
public void onFinished(JavaScriptObject jso) {
133136
grid.setList(JsUtils.<Application>jsoAsList(jso));
137+
refresh.setEnabled(true);
134138
}
135139

136140
@Override
@@ -141,10 +145,12 @@ public void onClick(ClickEvent event) {
141145
RegistrarManager.getApplicationsForUser(0, retry);
142146
}
143147
});
148+
refresh.setEnabled(true);
144149
}
145150

146151
@Override
147152
public void onLoadingStart() {
153+
refresh.setEnabled(false);
148154
grid.clearTable();
149155
grid.getLoaderWidget().onLoading(translation.loadingApplications());
150156
}

0 commit comments

Comments
 (0)