fix(core): Do not cache LDAP ExtSource

- Do not use same instance of LDAP ExtSource since they
  share their DirContext and can close it when others are
  in the middle of synchronization process.
- Removed empty class for already deleted ExtSourceVOOT.

(cherry picked from commit 7da88e8)

Author: zlamalp

perun-core/src/main/java/cz/metacentrum/perun/core/blImpl/ExtSourcesManagerBlImpl.java

@@ -31,6 +31,7 @@
 
 import cz.metacentrum.perun.core.bl.ExtSourcesManagerBl;
 import cz.metacentrum.perun.core.bl.PerunBl;
+import cz.metacentrum.perun.core.impl.ExtSourceLdap;
 import cz.metacentrum.perun.core.impl.Utils;
 import cz.metacentrum.perun.core.implApi.ExtSourceSimpleApi;
 import cz.metacentrum.perun.core.implApi.ExtSourcesManagerImplApi;
@@ -73,7 +74,7 @@ public void initialize(PerunSession sess) {
 
 	private Map<Integer,ExtSource> extSourcesByIdMap = new HashMap<>();
 	private Map<String,ExtSource> extSourcesByNameMap = new HashMap<>();
-	
+
 	private void cacheExtSourcesInMemory(PerunSession sess) {
 		Map<Integer,ExtSource> extSourcesByIdMap = new HashMap<>();
 		Map<String,ExtSource> extSourcesByNameMap = new HashMap<>();
@@ -112,34 +113,65 @@ public void deleteExtSource(PerunSession sess, ExtSource extSource) throws ExtSo
 	@Override
 	public ExtSource getExtSourceById(PerunSession sess, int id) throws InternalErrorException, ExtSourceNotExistsException {
 		ExtSource extSource = extSourcesByIdMap.get(id);
+		if (extSource instanceof ExtSourceLdap) {
+			// FIXME - retrieve new instance for LDAP ExtSources !!
+			return getExtSourcesManagerImpl().getExtSourceById(sess, id);
+		}
 		if (extSource == null) throw new ExtSourceNotExistsException("ExtSource with ID=" + id + " not exists");
 		return extSource;
 	}
 
 	@Override
 	public ExtSource getExtSourceByName(PerunSession sess, String name) throws InternalErrorException, ExtSourceNotExistsException {
 		ExtSource extSource = extSourcesByNameMap.get(name);
+		if (extSource instanceof ExtSourceLdap) {
+			// FIXME - retrieve new instance for LDAP ExtSources !!
+			return getExtSourcesManagerImpl().getExtSourceByName(sess, name);
+		}
 		if (extSource == null) throw new ExtSourceNotExistsException("ExtSource with name =" + name + " not exists");
 		return extSource;
 	}
 
 	@Override
 	public List<ExtSource> getVoExtSources(PerunSession sess, Vo vo) throws InternalErrorException {
 		List<Integer> ids = getExtSourcesManagerImpl().getVoExtSourcesIds(sess, vo);
-		return ids.stream().map(id -> extSourcesByIdMap.get(id)).collect(Collectors.toList());
+		return ids.stream().map(id -> { ExtSource extSource = extSourcesByIdMap.get(id);
+			if (extSource instanceof ExtSourceLdap) {
+				// FIXME - retrieve new instance for LDAP ExtSources !!
+				try {
+					return getExtSourcesManagerImpl().getExtSourceById(sess, id);
+				} catch (ExtSourceNotExistsException e) {
+					log.error("VO ExtSource by its ID doesn't exists!");
+					throw new ConsistencyErrorException("VO ExtSource by its ID doesn't exists!", e);
+				}
+			}
+			return extSource;
+		}).collect(Collectors.toList());
 	}
 
 	@Override
 	public List<ExtSource> getGroupExtSources(PerunSession sess, Group group) throws InternalErrorException {
 		List<Integer> ids = getExtSourcesManagerImpl().getGroupExtSourcesIds(sess, group);
-		return ids.stream().map(id -> extSourcesByIdMap.get(id)).collect(Collectors.toList());
+		return ids.stream().map(id -> { ExtSource extSource = extSourcesByIdMap.get(id);
+			if (extSource instanceof ExtSourceLdap) {
+				// FIXME - retrieve new instance for LDAP ExtSources !!
+				try {
+					return getExtSourcesManagerImpl().getExtSourceById(sess, id);
+				} catch (ExtSourceNotExistsException e) {
+					log.error("Group ExtSource by its ID doesn't exists!");
+					throw new ConsistencyErrorException("VO ExtSource by its ID doesn't exists!", e);
+				}
+			}
+			return extSource;
+		}).collect(Collectors.toList());
 	}
 
 	@Override
 	public List<ExtSource> getExtSources(PerunSession sess) throws InternalErrorException {
+		// FIXME - no need to retrieve new instance for LDAP ExtSources since its used only by outer API and tests.
 		return new ArrayList<>(extSourcesByIdMap.values());
 	}
-	
+
 	@Override
 	public void addExtSource(PerunSession sess, Vo vo, ExtSource source) throws ExtSourceAlreadyAssignedException {
 		getExtSourcesManagerImpl().addExtSource(sess, vo, source);