Merge pull request #4132 from zlamalp/transaction

HejdaJakub · web-flow · commit 87944e8cefce · 2023-11-07T09:59:32.000+01:00
fix(registrar): transaction for approving multiple applications
diff --git a/perun-registrar-lib/src/main/java/cz/metacentrum/perun/registrar/impl/RegistrarManagerImpl.java b/perun-registrar-lib/src/main/java/cz/metacentrum/perun/registrar/impl/RegistrarManagerImpl.java
@@ -1745,11 +1745,10 @@ public Application rejectApplication(PerunSession sess, int appId, String reason
 	}
 
 	@Override
-	@Transactional(rollbackFor = Exception.class)
 	public void rejectApplications(PerunSession sess, List<Integer> applicationIds, String reason) throws PerunException {
 		Collections.sort(applicationIds, Collections.reverseOrder());
 		for (Integer id : applicationIds) {
-			rejectApplication(sess, id, reason);
+			registrarManager.rejectApplication(sess, id, reason);
 		}
 	}
 
@@ -1851,7 +1850,6 @@ public Application approveApplication(PerunSession sess, int appId) throws Perun
 	}
 
 	@Override
-	@Transactional(rollbackFor = Exception.class)
 	public void approveApplications(PerunSession sess, List<Integer> applicationIds) throws PerunException {
 		Collections.sort(applicationIds);
 		for (Integer id : applicationIds) {

Original file line number	Diff line number	Diff line change
`@@ -1745,11 +1745,10 @@ public Application rejectApplication(PerunSession sess, int appId, String reason`
`1745`	`1745`	`}`
`1746`	`1746`
`1747`	`1747`	`@Override`
`1748`		`- @Transactional(rollbackFor = Exception.class)`
`1749`	`1748`	`public void rejectApplications(PerunSession sess, List<Integer> applicationIds, String reason) throws PerunException {`
`1750`	`1749`	`Collections.sort(applicationIds, Collections.reverseOrder());`
`1751`	`1750`	`for (Integer id : applicationIds) {`
`1752`		`- rejectApplication(sess, id, reason);`
	`1751`	`+ registrarManager.rejectApplication(sess, id, reason);`
`1753`	`1752`	`}`
`1754`	`1753`	`}`
`1755`	`1754`
`@@ -1851,7 +1850,6 @@ public Application approveApplication(PerunSession sess, int appId) throws Perun`
`1851`	`1850`	`}`
`1852`	`1851`
`1853`	`1852`	`@Override`
`1854`		`- @Transactional(rollbackFor = Exception.class)`
`1855`	`1853`	`public void approveApplications(PerunSession sess, List<Integer> applicationIds) throws PerunException {`
`1856`	`1854`	`Collections.sort(applicationIds);`
`1857`	`1855`	`for (Integer id : applicationIds) {`