fix(core): updated perunDefaultBlockedLoginChecker

Edited error message to contain list of user ids.
Check usage of all default blocked logins at once.

Author: sarkapalkovicova

perun-core/src/main/java/cz/metacentrum/perun/core/bl/AttributesManagerBl.java

@@ -432,6 +432,15 @@ public interface AttributesManagerBl {
 	 */
 	boolean isLoginAlreadyUsed(PerunSession sess, String login, String namespace);
 
+	/**
+	 * Gets IDs of users who use the given login in any namespace.
+	 *
+	 * @param sess perun session
+	 * @param login	login
+	 * @return list of user IDs
+	 */
+	List<Integer> getUserIdsByLogin(PerunSession sess, String login);
+
 	/**
 	 * Get all attributes associated with the UserExtSource which have name in list attrNames (empty and virtual too).
 	 *

perun-core/src/main/java/cz/metacentrum/perun/core/blImpl/AttributesManagerBlImpl.java

@@ -658,6 +658,11 @@ public boolean isLoginAlreadyUsed(PerunSession sess, String login, String namesp
 		return getAttributesManagerImpl().isLoginAlreadyUsed(sess, login, namespace);
 	}
 
+	@Override
+	public List<Integer> getUserIdsByLogin(PerunSession sess, String login) {
+		return getAttributesManagerImpl().getUserIdsByLogin(sess, login);
+	}
+
 	@Override
 	public List<Attribute> getAttributes(PerunSession sess, Host host) {
 		//get virtual attributes

perun-core/src/main/java/cz/metacentrum/perun/core/impl/AttributesManagerImpl.java

@@ -1263,7 +1263,16 @@ public boolean isLoginAlreadyUsed(PerunSession sess, String login, String namesp
 		}
 	}
 
-
+	public List<Integer> getUserIdsByLogin(PerunSession sess, String login) {
+		try {
+			return jdbc.queryForList("select distinct attr_val.user_id from attr_names as attr join user_attr_values attr_val on attr.id=attr_val.attr_id\n" +
+				"where attr.friendly_name like 'login-namespace:%%' \n" +
+				"    and attr.friendly_name not like '%%persistent%%' \n" +
+				"    and attr_val.attr_value like ?", Integer.class, login);
+		} catch (RuntimeException ex) {
+			throw new InternalErrorException(ex);
+		}
+	}
 
 	@Override
 	public List<Attribute> getAttributes(PerunSession sess, UserExtSource ues, List<String> attrNames) {

perun-core/src/main/java/cz/metacentrum/perun/core/impl/DefaultBlockedLoginChecker.java

@@ -10,6 +10,8 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import java.util.HashMap;
+import java.util.List;
 import java.util.Set;
 
 /**
@@ -41,13 +43,21 @@ public void setPerunBl(PerunBl perunBl) {
 	public void checkDefaultBlockedLogins() {
 		log.debug("DefaultBlockedLoginChecker starts checking default blocked logins.");
 
+		HashMap<String, List<Integer>> usagesOfDefaultBlockedLogin = new HashMap<>();
+
 		Set<String> logins = BeansUtils.getCoreConfig().getBlockedLogins();
 		for (String login : logins) {
-			if (perunBl.getAttributesManagerBl().isLoginAlreadyUsed(sess, login, null)) {
+			List<Integer> userIds = perunBl.getAttributesManagerBl().getUserIdsByLogin(sess, login);
+			if (!userIds.isEmpty()) {
 				log.error("Login {} can not be blocked by default because it is already used.", login);
-				throw new InternalErrorException("Login " + login + " can not be blocked by default because it is already used. Please edit the core config!");
+				usagesOfDefaultBlockedLogin.put(login, userIds);
 			}
 		}
+
+		if (!usagesOfDefaultBlockedLogin.isEmpty()) {
+			throw new InternalErrorException("Default blocked logins in core config contain logins that users already use: " + usagesOfDefaultBlockedLogin);
+
+		}
 	}
 
 }

perun-core/src/main/java/cz/metacentrum/perun/core/implApi/AttributesManagerImplApi.java

@@ -496,6 +496,15 @@ public interface AttributesManagerImplApi {
 	 */
 	boolean isLoginAlreadyUsed(PerunSession sess, String login, String namespace);
 
+	/**
+	 * Gets IDs of users who use the given login in any namespace.
+	 *
+	 * @param sess perun session
+	 * @param login	login
+	 * @return list of user IDs
+	 */
+	List<Integer> getUserIdsByLogin(PerunSession sess, String login);
+
 	/**
 	 * Get all virtual attributes associated with the user.
 	 *