From 0e1b33ea2cf9a491bac0a828be9dbc95164d80c7 Mon Sep 17 00:00:00 2001 From: 070bex424pankaj Date: Mon, 17 Feb 2025 18:07:09 +0545 Subject: [PATCH 1/7] Add number input method to Slack block kit layout --- lib/slack/block_kit/layout/input.rb | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/lib/slack/block_kit/layout/input.rb b/lib/slack/block_kit/layout/input.rb index 46e9469..614f6a3 100644 --- a/lib/slack/block_kit/layout/input.rb +++ b/lib/slack/block_kit/layout/input.rb @@ -216,6 +216,29 @@ def plain_text_input( self end + def number_input( + action_id:, + placeholder: nil, + initial_value: nil, + is_decimal_allowed: nil, + focus_on_load: nil, + dispatch_action_config: nil, + min_value: nil, + max_value: nil + ) + @element = Element::PlainTextInput.new( + action_id: action_id, + placeholder: placeholder, + initial_value: initial_value, + is_decimal_allowed: is_decimal_allowed, + focus_on_load: focus_on_load, + min_value: min_value, + max_value: max_value + ) + + self + end + def url_text_input( action_id:, placeholder: nil, From cabdd602af8ba464ec8bc6e772c55450d39c41a7 Mon Sep 17 00:00:00 2001 From: 070bex424pankaj Date: Mon, 17 Feb 2025 18:09:46 +0545 Subject: [PATCH 2/7] Change PlainTextInput to NumberInput in Slack block kit layout --- lib/slack/block_kit/layout/input.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/slack/block_kit/layout/input.rb b/lib/slack/block_kit/layout/input.rb index 614f6a3..58b2303 100644 --- a/lib/slack/block_kit/layout/input.rb +++ b/lib/slack/block_kit/layout/input.rb @@ -226,7 +226,7 @@ def number_input( min_value: nil, max_value: nil ) - @element = Element::PlainTextInput.new( + @element = Element::NumberInput.new( action_id: action_id, placeholder: placeholder, initial_value: initial_value, From 38c76c523a296f82ecf5421cdf37be0938373298 Mon Sep 17 00:00:00 2001 From: 070bex424pankaj Date: Mon, 17 Feb 2025 18:19:12 +0545 Subject: [PATCH 3/7] refactor arguments pass --- lib/slack/block_kit/layout/input.rb | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/lib/slack/block_kit/layout/input.rb b/lib/slack/block_kit/layout/input.rb index 58b2303..db78e62 100644 --- a/lib/slack/block_kit/layout/input.rb +++ b/lib/slack/block_kit/layout/input.rb @@ -218,22 +218,21 @@ def plain_text_input( def number_input( action_id:, + is_decimal_allowed: nil, placeholder: nil, initial_value: nil, - is_decimal_allowed: nil, - focus_on_load: nil, - dispatch_action_config: nil, min_value: nil, - max_value: nil + max_value: nil, + focus_on_load: nil, ) @element = Element::NumberInput.new( action_id: action_id, + is_decimal_allowed: is_decimal_allowed, placeholder: placeholder, initial_value: initial_value, - is_decimal_allowed: is_decimal_allowed, - focus_on_load: focus_on_load, min_value: min_value, max_value: max_value + focus_on_load: focus_on_load, ) self From 0fe300f94970a898e93ecdd8667d4eac0e7451c4 Mon Sep 17 00:00:00 2001 From: 070bex424pankaj Date: Mon, 17 Feb 2025 18:20:59 +0545 Subject: [PATCH 4/7] Fix formatting in input.rb for focus_on_load parameter --- lib/slack/block_kit/layout/input.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/slack/block_kit/layout/input.rb b/lib/slack/block_kit/layout/input.rb index db78e62..9e34050 100644 --- a/lib/slack/block_kit/layout/input.rb +++ b/lib/slack/block_kit/layout/input.rb @@ -232,7 +232,7 @@ def number_input( initial_value: initial_value, min_value: min_value, max_value: max_value - focus_on_load: focus_on_load, + focus_on_load: focus_on_load ) self From bd251ab5c091f9e9c8a0f6b5b53802fa03ed0ab6 Mon Sep 17 00:00:00 2001 From: 070bex424pankaj Date: Mon, 17 Feb 2025 18:21:20 +0545 Subject: [PATCH 5/7] Add missing comma in input.rb for max_value parameter --- lib/slack/block_kit/layout/input.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/slack/block_kit/layout/input.rb b/lib/slack/block_kit/layout/input.rb index 9e34050..5c1cfcb 100644 --- a/lib/slack/block_kit/layout/input.rb +++ b/lib/slack/block_kit/layout/input.rb @@ -231,7 +231,7 @@ def number_input( placeholder: placeholder, initial_value: initial_value, min_value: min_value, - max_value: max_value + max_value: max_value, focus_on_load: focus_on_load ) From acc3986318dbc839f91fc42a0499eb90e2051e35 Mon Sep 17 00:00:00 2001 From: 070bex424pankaj Date: Mon, 17 Feb 2025 18:26:39 +0545 Subject: [PATCH 6/7] Fix formatting in input.rb for focus_on_load parameter --- lib/slack/block_kit/layout/input.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/slack/block_kit/layout/input.rb b/lib/slack/block_kit/layout/input.rb index 5c1cfcb..0f36a50 100644 --- a/lib/slack/block_kit/layout/input.rb +++ b/lib/slack/block_kit/layout/input.rb @@ -223,7 +223,7 @@ def number_input( initial_value: nil, min_value: nil, max_value: nil, - focus_on_load: nil, + focus_on_load: nil ) @element = Element::NumberInput.new( action_id: action_id, From b335c960ce9e1b68be1d9251b63b4bcdb88ecea7 Mon Sep 17 00:00:00 2001 From: 070bex424pankaj Date: Tue, 18 Feb 2025 10:17:36 +0545 Subject: [PATCH 7/7] Update CHANGELOG.md to document fix for Slack::BlockKit::Layout.Input access issue --- CHANGELOG.md | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index de73341..5171c4d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,23 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] -### Added -- N/A - -### Changed -- N/A - -### Deprecated -- N/A - -### Removed -- N/A - ### Fixed -- N/A - -### Security -- N/A +- Fixed the issue when accessing Slack::BlockKit::Layout.Input (#197 by @070bex424pankaj) ## [0.25.0] - 2024-11-22