Skip to content

Commit d9b0cdd

Browse files
committed
[CHERIoT] Clean up direct references to the "cheriot" CPU name in favor of FeatureVendorXCheriot1
1 parent e91f708 commit d9b0cdd

File tree

4 files changed

+7
-6
lines changed

4 files changed

+7
-6
lines changed

llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1828,7 +1828,7 @@ bool RISCVAsmParser::matchAndEmitInstruction(SMLoc IDLoc, unsigned &Opcode,
18281828
"an integer in the range");
18291829
case Match_InvalidUImm20AUIPC:
18301830
// FIXME: This should be keyed off an Xcheriot feature, not a CPU name.
1831-
if (getSTI().getCPU() == "cheriot")
1831+
if (getSTI().hasFeature(RISCV::FeatureVendorXCheriot1))
18321832
return generateImmOutOfRangeError(
18331833
Operands, ErrorInfo, 0, (1 << 20) - 1,
18341834
"operand must be a symbol with a "

llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,9 +147,9 @@ void validate(const Triple &TT, const FeatureBitset &FeatureBits) {
147147
report_fatal_error("RV32 and RV64 can't be combined");
148148
if (FeatureBits[RISCV::FeatureVendorXCheriot1]) {
149149
if (!FeatureBits[RISCV::FeatureVendorXCheri])
150-
report_fatal_error("XCheriotV1 extension requires XCheri extension");
150+
report_fatal_error("XCheriot1 extension requires XCheri extension");
151151
if (!FeatureBits[RISCV::FeatureCapMode])
152-
report_fatal_error("XCheriotV1 extension requires CapMode");
152+
report_fatal_error("XCheriot1 extension requires CapMode");
153153
}
154154
}
155155

llvm/lib/Target/RISCV/MCTargetDesc/RISCVCompressedCap.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ namespace RISCVCompressedCap {
1818

1919
static inline CompressedCapability::CapabilityFormat
2020
GetCapabilitySize(const MCSubtargetInfo &STI) {
21-
if (STI.getCPU() == "cheriot")
21+
if (STI.hasFeature(RISCV::FeatureVendorXCheriot1))
2222
return CompressedCapability::Cheriot64;
2323

2424
bool IsRV64 = STI.hasFeature(RISCV::Feature64Bit);

llvm/lib/Target/RISCV/MCTargetDesc/RISCVELFObjectWriter.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,8 +108,9 @@ unsigned RISCVELFObjectWriter::getRelocType(MCContext &Ctx,
108108
return ELF::R_RISCV_CHERI_CJAL;
109109
case RISCV::fixup_riscv_ccall: {
110110
const auto *STI = Ctx.getSubtargetInfo();
111-
if (STI->getCPU() == "cheriot" || STI->getTargetTriple().getSubArch() ==
112-
Triple::RISCV32SubArch_cheriot_v1)
111+
if (STI->hasFeature(RISCV::FeatureVendorXCheriot1) ||
112+
STI->getTargetTriple().getSubArch() ==
113+
Triple::RISCV32SubArch_cheriot_v1)
113114
return ELF::R_RISCV_CHERIOT_CCALL;
114115
return ELF::R_RISCV_CHERI_CCALL;
115116
}

0 commit comments

Comments
 (0)