tcpip: de-templatize with_sealed_socket.

This makes us save 128B. The check is on the error path anyways and is
irrelevant to performance.

Signed-off-by: Hugo Lefeuvre <[email protected]>

Author: hlef

lib/tcpip/network_wrapper.cc

@@ -106,9 +106,9 @@ namespace
 	 * the socket is coming from a previous instantiation of the network
 	 * stack.
 	 */
-	template<bool IsCloseOperation = false>
 	int with_sealed_socket(FunctionWrapper<int(SealedSocket *socket)> operation,
-	                       Sealed<SealedSocket> sealedSocket)
+	                       Sealed<SealedSocket> sealedSocket,
+	                       bool                 isCloseOperation = false)
 	{
 		return with_restarting_checks(
 		  [&]() {
@@ -126,7 +126,7 @@ namespace
 				    "(epochs mismatch: socket = {}; current = {}).",
 				    socket->socketEpoch,
 				    currentSocketEpoch.load());
-				  if constexpr (!IsCloseOperation)
+				  if (!isCloseOperation)
 				  {
 					  // This should push the caller to free the socket.
 					  return -ENOTCONN;
@@ -792,7 +792,7 @@ int network_socket_close(Timeout            *t,
 	{
 		return -EINVAL;
 	}
-	return with_sealed_socket<true /* this is a close operation */>(
+	return with_sealed_socket(
 	  [=](SealedSocket *socket) {
 		  // We will fail to lock if the socket is coming from
 		  // a previous instance of the network stack as it set
@@ -969,7 +969,8 @@ int network_socket_close(Timeout            *t,
 		  }
 		  return -ETIMEDOUT;
 	  },
-	  sealedSocket);
+	  sealedSocket,
+	  true /* this is a close operation */);
 }
 
 NetworkReceiveResult