mqtt: correct timeout conversion to msec

nwf · rmn30 · nwf · commit e2f259727cff · 2025-03-20T14:04:25.000-04:00
Full credit to RNW for finding this one.

Co-authored-by: Robert Norton-Wright &lt;robert.norton@scisemi.com&gt;
diff --git a/lib/mqtt/mqtt.cc b/lib/mqtt/mqtt.cc
@@ -710,7 +710,7 @@ MQTTConnection mqtt_connect(Timeout                    *t,
 	do
 	{
 		// `remaining` is in milliseconds
-		uint32_t remaining = (t->remaining * MS_PER_TICK) / 1000;
+		uint32_t remaining = (t->remaining * MS_PER_TICK);
 		ret                = with_elapse_timeout(t, [&]() {
             return MQTT_Connect(&context->coreMQTTContext,
                                 &connectInfo,

Original file line number	Diff line number	Diff line change
`@@ -710,7 +710,7 @@ MQTTConnection mqtt_connect(Timeout *t,`
`710`	`710`	`do`
`711`	`711`	`{`
`712`	`712`	// `remaining` is in milliseconds
`713`		`- uint32_t remaining = (t->remaining * MS_PER_TICK) / 1000;`
	`713`	`+ uint32_t remaining = (t->remaining * MS_PER_TICK);`
`714`	`714`	`ret = with_elapse_timeout(t, [&]() {`
`715`	`715`	`return MQTT_Connect(&context->coreMQTTContext,`
`716`	`716`	`&connectInfo,`