Fix --help output for options without a short flag (again). #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Apparently on this branch the relevant upstream commit is 34a32a2 not sure why it has a different hash. Update: most likely due to committer info etc. being added when it was merged upstream (I was looking at the commit from the PR). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The simulator --help output container unprintable characters for options without a short flag.
This was previously fixed in ffa591d but broken again in 037c835.
This reverts the relevant lines to the upstream version.
Since this branch is regularly rebased we could optionally merge the fix with the latter commit and remove the diff from upstream entirely.