pylint

Author: christopher-wild

causal_testing/generation/enum_gen.py

@@ -12,6 +12,7 @@ class EnumGen(rv_discrete):
     abstract test cases."""
 
     def __init__(self, datatype: Enum):
+        super().__init__()
         self.datatype = dict(enumerate(datatype, 1))
         self.inverse_dt = {v: k for k, v in self.datatype.items()}
 
@@ -28,16 +29,16 @@ def ppf(self, q):
         """
         return np.vectorize(self.datatype.get)(np.ceil(len(self.datatype) * q))
 
-    def cdf(self, q):
+    def cdf(self, k):
         """
         Cumulative distribution function of the given RV.
         Parameters
         ----------
-        q : array_like
+        k : array_like
             quantiles
         Returns
         -------
         cdf : ndarray
             Cumulative distribution function evaluated at `x`
         """
-        return np.vectorize(self.inverse_dt.get)(q) / len(self.datatype)
+        return np.vectorize(self.inverse_dt.get)(k) / len(self.datatype)

causal_testing/json_front/json_class.py

@@ -20,7 +20,6 @@
 from causal_testing.specification.causal_specification import CausalSpecification
 from causal_testing.specification.scenario import Scenario
 from causal_testing.specification.variable import Input, Meta, Output
-from causal_testing.testing.base_test_case import BaseTestCase
 from causal_testing.testing.causal_test_case import CausalTestCase
 from causal_testing.testing.causal_test_engine import CausalTestEngine
 from causal_testing.testing.estimators import Estimator
@@ -86,7 +85,6 @@ def _create_abstract_test_case(self, test, mutates, effects):
             treatment_var.distribution = getattr(scipy.stats, dist)(**params)
             self._append_to_file(treatment_var.name + f" {dist}({params})", logging.INFO)
 
-        print("!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!")
         abstract_test = AbstractCausalTestCase(
             scenario=self.scenario,
             intervention_constraints=[mutates[v](k) for k, v in test["mutations"].items()],
@@ -139,22 +137,23 @@ def run_json_tests(self, effects: dict, estimators: dict, f_flag: bool = False,
                     ]
                     failures = self._execute_tests(concrete_tests, test, f_flag)
                     msg = (
-                            f"Executing test: {test['name']} \n"
-                            + f"  {concrete_tests[0]} \n"
-                            + f"  {failures}/{len(concrete_tests)} failed for {test['name']}"
+                        f"Executing test: {test['name']} \n"
+                        + f"  {concrete_tests[0]} \n"
+                        + f"  {failures}/{len(concrete_tests)} failed for {test['name']}"
                     )
                 else:
                     abstract_test = self._create_abstract_test_case(test, mutates, effects)
                     concrete_tests, dummy = abstract_test.generate_concrete_tests(5, 0.05)
                     failures = self._execute_tests(concrete_tests, test, f_flag)
 
                     msg = (
-                            f"Executing test: {test['name']} \n"
-                            + "  abstract_test \n"
-                            + f"  {abstract_test} \n"
-                            + f"  {abstract_test.treatment_variable.name},{abstract_test.treatment_variable.distribution} \n"
-                            + f"  Number of concrete tests for test case: {str(len(concrete_tests))} \n"
-                            + f"  {failures}/{len(concrete_tests)} failed for {test['name']}"
+                        f"Executing test: {test['name']} \n"
+                        + "  abstract_test \n"
+                        + f"  {abstract_test} \n"
+                        + f"  {abstract_test.treatment_variable.name},"
+                        + f"  {abstract_test.treatment_variable.distribution} \n"
+                        + f"  Number of concrete tests for test case: {str(len(concrete_tests))} \n"
+                        + f"  {failures}/{len(concrete_tests)} failed for {test['name']}"
                     )
                 self._append_to_file(msg, logging.INFO)
             else:
@@ -179,11 +178,11 @@ def run_json_tests(self, effects: dict, estimators: dict, f_flag: bool = False,
                     result = "passed"
 
                 msg = (
-                        f"Executing concrete test: {test['name']} \n"
-                        + f"treatment variable: {test['treatment_variable']} \n"
-                        + f"outcome_variable = {outcome_variable} \n"
-                        + f"control value = {test['control_value']}, treatment value = {test['treatment_value']} \n"
-                        + f"result - {result}"
+                    f"Executing concrete test: {test['name']} \n"
+                    + f"treatment variable: {test['treatment_variable']} \n"
+                    + f"outcome_variable = {outcome_variable} \n"
+                    + f"control value = {test['control_value']}, treatment value = {test['treatment_value']} \n"
+                    + f"result - {result}"
                 )
                 self._append_to_file(msg, logging.INFO)
 
@@ -258,7 +257,7 @@ def _execute_test_case(self, causal_test_case: CausalTestCase, test: Iterable[Ma
         return failed
 
     def _setup_test(
-            self, causal_test_case: CausalTestCase, test: Mapping, conditions: list[str] = None
+        self, causal_test_case: CausalTestCase, test: Mapping, conditions: list[str] = None
     ) -> tuple[CausalTestEngine, Estimator]:
         """Create the necessary inputs for a single test case
         :param causal_test_case: The concrete test case to be executed
@@ -343,7 +342,7 @@ def get_args(test_args=None) -> argparse.Namespace:
         parser.add_argument(
             "-w",
             help="Specify to overwrite any existing output files. This can lead to the loss of existing outputs if not "
-                 "careful",
+            "careful",
             action="store_true",
         )
         parser.add_argument(

tests/json_front_tests/test_json_class.py

@@ -2,17 +2,15 @@
 from pathlib import Path
 from statistics import StatisticsError
 import scipy
-import csv
-import json
+
 
 from causal_testing.testing.estimators import LinearRegressionEstimator
 from causal_testing.testing.causal_test_outcome import NoEffect, Positive
-from tests.test_helpers import create_temp_dir_if_non_existent, remove_temp_dir_if_existent
+from tests.test_helpers import remove_temp_dir_if_existent
 from causal_testing.json_front.json_class import JsonUtility, CausalVariables
 from causal_testing.specification.variable import Input, Output, Meta
 from causal_testing.specification.scenario import Scenario
 from causal_testing.specification.causal_specification import CausalSpecification
-from causal_testing.generation.abstract_causal_test_case import AbstractCausalTestCase
 
 
 class TestJsonClass(unittest.TestCase):
@@ -151,7 +149,8 @@ def test_run_json_tests_from_json(self):
 
         self.json_class.run_json_tests(effects=effects, estimators=estimators, f_flag=False, mutates=mutates)
 
-        # Test that the final log message prints that failed tests are printed, which is expected behaviour for this scenario
+        # Test that the final log message prints that failed tests are printed, which is expected behaviour for this
+        # scenario
         with open("temp_out.txt", "r") as reader:
             temp_out = reader.readlines()
         self.assertIn("failed", temp_out[-1])