Update json tests

Author: christopher-wild

causal_testing/json_front/json_class.py

@@ -110,10 +110,9 @@ def generate_tests(self, effects: dict, mutates: dict, estimators: dict, f_flag:
                   f"abstract_test \n" + \
                   f"{abstract_test} \n" + \
                   f"{abstract_test.treatment_variable.name},{abstract_test.treatment_variable.distribution} \n" + \
-                  f"Number of concrete tests for test case: {str(len(concrete_tests))}"
-
-        self.append_to_file(msg, logging.INFO)
-
+                  f"Number of concrete tests for test case: {str(len(concrete_tests))} \n" + \
+                  f"{failures}/{len(concrete_tests)} failed for {test['name']}"
+            self._append_to_file(msg, logging.INFO)
 
     def _execute_tests(self, concrete_tests, estimators, test, f_flag):
         failures = 0
@@ -123,7 +122,6 @@ def _execute_tests(self, concrete_tests, estimators, test, f_flag):
                 failures += 1
         return failures
 
-
     def _json_parse(self):
         """Parse a JSON input file into inputs, outputs, metas and a test plan"""
         with open(self.input_paths.json_path, encoding="utf-8") as f:
@@ -133,7 +131,6 @@ def _json_parse(self):
             self.data.append(df)
         self.data = pd.concat(self.data)
 
-
     def _populate_metas(self):
         """
         Populate data with meta-variable values and add distributions to Causal Testing Framework Variables
@@ -146,8 +143,7 @@ def _populate_metas(self):
                 fitter.fit()
                 (dist, params) = list(fitter.get_best(method="sumsquare_error").items())[0]
                 var.distribution = getattr(scipy.stats, dist)(**params)
-                self.append_to_file(var.name + f" {dist}({params})", logging.INFO)
-
+                self._append_to_file(var.name + f" {dist}({params})", logging.INFO)
 
     def _execute_test_case(self, causal_test_case: CausalTestCase, estimator: Estimator, f_flag: bool) -> bool:
         """Executes a singular test case, prints the results and returns the test case result
@@ -181,11 +177,10 @@ def _execute_test_case(self, causal_test_case: CausalTestCase, estimator: Estima
             )
         if not test_passes:
             failed = True
-            self.append_to_file(f"FAILED- expected {causal_test_case.expected_causal_effect}, got {result_string}",
-                                logging.WARNING)
+            self._append_to_file(f"FAILED- expected {causal_test_case.expected_causal_effect}, got {result_string}",
+                                 logging.WARNING)
         return failed
 
-
     def _setup_test(self, causal_test_case: CausalTestCase, estimator: Estimator) -> tuple[CausalTestEngine, Estimator]:
         """Create the necessary inputs for a single test case
         :param causal_test_case: The concrete test case to be executed
@@ -214,28 +209,24 @@ def _setup_test(self, causal_test_case: CausalTestCase, estimator: Estimator) ->
 
         return causal_test_engine, estimation_model
 
-
     def add_modelling_assumptions(self, estimation_model: Estimator):  # pylint: disable=unused-argument
         """Optional abstract method where user functionality can be written to determine what assumptions are required
         for specific test cases
         :param estimation_model: estimator model instance for the current running test.
         """
         return
 
-
-    def append_to_file(self, line: str, log_level: int = None):
+    def _append_to_file(self, line: str, log_level: int = None):
         with open(self.output_path, "a") as f:
-            f.write(line+"\n")
+            f.write(line + "\n")
         if log_level:
             logger.log(level=log_level, msg=line)
 
-
     @staticmethod
     def check_file_exists(output_path: Path, overwrite: bool):
         if not overwrite and output_path.is_file():
             raise FileExistsError(f"Chosen file output ({output_path}) already exists")
 
-
     @staticmethod
     def get_args(test_args=None) -> argparse.Namespace:
         """Command-line arguments

tests/json_front_tests/test_json_class.py

@@ -29,7 +29,7 @@ def setUp(self) -> None:
         self.json_path = str(test_data_dir_path / json_file_name)
         self.dag_path = str(test_data_dir_path / dag_file_name)
         self.data_path = [str(test_data_dir_path / data_file_name)]
-        self.json_class = JsonUtility("logs.log")
+        self.json_class = JsonUtility("temp_out.txt", True)
         self.example_distribution = scipy.stats.uniform(1, 10)
         self.input_dict_list = [{"name": "test_input", "datatype": float, "distribution": self.example_distribution}]
         self.output_dict_list = [{"name": "test_output", "datatype": float}]
@@ -95,11 +95,12 @@ def test_generate_tests_from_json(self):
         }
         estimators = {"LinearRegressionEstimator": LinearRegressionEstimator}
 
-        with self.assertLogs() as captured:
-            self.json_class.generate_tests(effects, mutates, estimators, False)
+        self.json_class.generate_tests(effects, mutates, estimators, False)
 
         # Test that the final log message prints that failed tests are printed, which is expected behaviour for this scenario
-        self.assertIn("failed", captured.records[-1].getMessage())
+        with open("temp_out.txt", 'r') as reader:
+            temp_out = reader.readlines()
+        self.assertIn("failed", temp_out[-1])
 
     def tearDown(self) -> None:
         pass