Skip to content

Commit 2a26864

Browse files
committed
fix: skip parameter should default to False
1 parent e54a01a commit 2a26864

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

causal_testing/testing/metamorphic_relation.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,14 +39,14 @@ class ShouldCause(MetamorphicRelation):
3939

4040
def to_json_stub(
4141
self,
42-
skip: bool = True,
42+
skip: bool = False,
4343
estimate_type: str = "coefficient",
4444
effect_type: str = "direct",
4545
estimator: str = "LinearRegressionEstimator",
4646
) -> dict:
4747
"""
4848
Convert to a JSON frontend stub string for user customisation.
49-
:param skip: Whether to skip the test
49+
:param skip: Whether to skip the test (default False).
5050
:param effect_type: The type of causal effect to consider (total or direct)
5151
:param estimate_type: The estimate type to use when evaluating tests
5252
:param estimator: The name of the estimator class to use when evaluating the test
@@ -77,14 +77,14 @@ class ShouldNotCause(MetamorphicRelation):
7777

7878
def to_json_stub(
7979
self,
80-
skip: bool = True,
80+
skip: bool = False,
8181
estimate_type: str = "coefficient",
8282
effect_type: str = "direct",
8383
estimator: str = "LinearRegressionEstimator",
8484
) -> dict:
8585
"""
8686
Convert to a JSON frontend stub string for user customisation.
87-
:param skip: Whether to skip the test
87+
:param skip: Whether to skip the test (default False).
8888
:param effect_type: The type of causal effect to consider (total or direct)
8989
:param estimate_type: The estimate type to use when evaluating tests
9090
:param estimator: The name of the estimator class to use when evaluating the test
@@ -244,6 +244,10 @@ def generate_causal_tests(
244244
if len(list(causal_dag.graph.predecessors(relation.base_test_case.outcome_variable))) > 0
245245
]
246246

247+
logger.warning("The skip parameter is hard-coded to False during test generation for better integration with the "
248+
"causal testing component (python -m causal_testing test ...)"
249+
"Please carefully review the generated tests and decide which to skip.")
250+
247251
logger.info(f"Generated {len(tests)} tests. Saving to {output_path}.")
248252
with open(output_path, "w", encoding="utf-8") as f:
249253
json.dump({"tests": tests}, f, indent=2)

0 commit comments

Comments
 (0)