pylint

Author: jmafoster1

causal_testing/json_front/json_class.py

@@ -146,7 +146,7 @@ def run_json_tests(self, effects: dict, estimators: dict, f_flag: bool = False,
                     )
                 else:
                     abstract_test = self._create_abstract_test_case(test, mutates, effects)
-                    concrete_tests, dummy = abstract_test.generate_concrete_tests(5, 0.05)
+                    concrete_tests, _ = abstract_test.generate_concrete_tests(5, 0.05)
                     failures, _ = self._execute_tests(concrete_tests, test, f_flag)
 
                     msg = (
@@ -176,17 +176,13 @@ def run_json_tests(self, effects: dict, estimators: dict, f_flag: bool = False,
                     estimate_type=test["estimate_type"],
                 )
                 failed, _ = self._execute_test_case(causal_test_case=causal_test_case, test=test, f_flag=f_flag)
-                if failed:
-                    result = "failed"
-                else:
-                    result = "passed"
 
                 msg = (
                     f"Executing concrete test: {test['name']} \n"
                     + f"treatment variable: {test['treatment_variable']} \n"
                     + f"outcome_variable = {outcome_variable} \n"
                     + f"control value = {test['control_value']}, treatment value = {test['treatment_value']} \n"
-                    + f"result - {result}"
+                    + f"Result: {'FAILED' if failed else 'Passed'}"
                 )
                 self._append_to_file(msg, logging.INFO)
 

tests/json_front_tests/test_json_class.py

@@ -234,7 +234,7 @@ def test_run_concrete_json_testcase(self):
         self.json_class.run_json_tests(effects=effects, estimators=estimators, f_flag=False)
         with open("temp_out.txt", "r") as reader:
             temp_out = reader.readlines()
-        self.assertIn("failed", temp_out[-1])
+        self.assertIn("FAILED", temp_out[-1])
 
     def tearDown(self) -> None:
         remove_temp_dir_if_existent()