Skip to content

Commit 607e7e8

Browse files
refactor assert to if
1 parent d146cd6 commit 607e7e8

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

causal_testing/json_front/json_class.py

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
from dataclasses import dataclass
99
from pathlib import Path
10+
from statistics import StatisticsError
1011

1112
import pandas as pd
1213
import scipy
@@ -171,16 +172,14 @@ def _execute_test_case(self, causal_test_case: CausalTestCase, estimator: Estima
171172
)
172173
else:
173174
result_string = f"{causal_test_result.test_value.value} no confidence intervals"
174-
if f_flag:
175-
assert test_passes, (
176-
f"{causal_test_case}\n FAILED - expected {causal_test_case.expected_causal_effect}, "
177-
f"got {result_string}"
178-
)
175+
179176
if not test_passes:
177+
if f_flag:
178+
raise StatisticsError(
179+
f"{causal_test_case}\n FAILED - expected {causal_test_case.expected_causal_effect}, "
180+
f"got {result_string}")
180181
failed = True
181-
self._append_to_file(
182-
f"FAILED- expected {causal_test_case.expected_causal_effect}, got {result_string}", logging.WARNING
183-
)
182+
logger.warning(" FAILED- expected %s, got %s", causal_test_case.expected_causal_effect, result_string)
184183
return failed
185184

186185
def _setup_test(self, causal_test_case: CausalTestCase, estimator: Estimator) -> tuple[CausalTestEngine, Estimator]:

0 commit comments

Comments
 (0)