pytests

Author: jmafoster1

causal_testing/testing/causal_effect.py

@@ -79,17 +79,29 @@ class ExactValue(CausalEffect):
     def __init__(self, value: float, atol: float = None, ci_low: float = None, ci_high: float = None):
         if (ci_low is not None) ^ (ci_high is not None):
             raise ValueError("If specifying confidence intervals, must specify `ci_low` and `ci_high` parameters.")
+        if atol is not None and atol < 0:
+            raise ValueError("Tolerance must be an absolute (positive) value.")
+
         self.value = value
         self.ci_low = ci_low
         self.ci_high = ci_high
         self.atol = atol if atol is not None else abs(value * 0.05)
-        if self.atol < 0:
-            raise ValueError("Tolerance must be an absolute (positive) value.")
+
+        if self.ci_low is not None and self.ci_high is not None:
+            if not self.ci_low <= self.value <= self.ci_high:
+                raise ValueError("Specified value falls outside the specified confidence intervals.")
+                if self.value - self.atol < self.ci_low or self.value + self.atol > self.ci_high:
+                    raise ValueError(
+                        "Arithmetic tolerance falls outside the confidence intervals. Try specifyin a smaller value of atol."
+                    )
 
     def apply(self, res: CausalTestResult) -> bool:
         close = np.isclose(res.test_value.value, self.value, atol=self.atol)
         if res.ci_valid() and self.ci_low is not None and self.ci_high is not None:
-            return close and self.ci_low <= res.ci_low() and self.ci_high >= res.ci_high()
+            return all(
+                close and ci_low <= ci_low and ci_high >= ci_high
+                for ci_low, ci_high in zip(res.ci_low(), res.ci_high())
+            )
         return close
 
     def __str__(self):

tests/testing_tests/test_causal_test_outcome.py renamed to tests/testing_tests/test_causal_effect.py

@@ -181,6 +181,28 @@ def test_exactValue_pass_ci(self):
         ev = ExactValue(5, 0.1)
         self.assertTrue(ev.apply(ctr))
 
+    def test_exactValue_ci_pass_ci(self):
+        test_value = TestValue(type="ate", value=pd.Series(5.05))
+        ctr = CausalTestResult(
+            estimator=self.estimator,
+            test_value=test_value,
+            confidence_intervals=[pd.Series(4.1), pd.Series(5.9)],
+            effect_modifier_configuration=None,
+        )
+        ev = ExactValue(5, ci_low=4, ci_high=6)
+        self.assertTrue(ev.apply(ctr))
+
+    def test_exactValue_ci_fail_ci(self):
+        test_value = TestValue(type="ate", value=pd.Series(5.05))
+        ctr = CausalTestResult(
+            estimator=self.estimator,
+            test_value=test_value,
+            confidence_intervals=[pd.Series(3.9), pd.Series(6.1)],
+            effect_modifier_configuration=None,
+        )
+        ev = ExactValue(5, ci_low=4, ci_high=6)
+        self.assertTrue(ev.apply(ctr))
+
     def test_exactValue_fail(self):
         test_value = TestValue(type="ate", value=pd.Series(0))
         ctr = CausalTestResult(
@@ -196,6 +218,22 @@ def test_invalid_atol(self):
         with self.assertRaises(ValueError):
             ExactValue(5, -0.1)
 
+    def test_unspecified_ci_high(self):
+        with self.assertRaises(ValueError):
+            ExactValue(5, ci_low=-0.1)
+
+    def test_unspecified_ci_low(self):
+        with self.assertRaises(ValueError):
+            ExactValue(5, ci_high=-0.1)
+
+    def test_invalid_ci_range(self):
+        with self.assertRaises(ValueError):
+            ExactValue(5, ci_low=6, ci_high=7, atol=0.05)
+
+    def test_invalid_ci_atol(self):
+        with self.assertRaises(ValueError):
+            ExactValue(1000, ci_low=1001, ci_high=1002, atol=0.05)
+
     def test_invalid(self):
         test_value = TestValue(type="invalid", value=pd.Series(5.05))
         ctr = CausalTestResult(