Updated IV check to explicitly use len

jmafoster1 · web-flow · commit 75efc80b99cc · 2024-11-27T10:55:40.000Z
diff --git a/causal_testing/specification/causal_dag.py b/causal_testing/specification/causal_dag.py
@@ -173,8 +173,8 @@ def check_iv_assumptions(self, treatment, outcome, instrument) -> bool:
             (
                 cause
                 for cause in self.graph.nodes
-                if list(nx.all_simple_paths(self.graph, source=cause, target=instrument))
-                and list(nx.all_simple_paths(self.graph, source=cause, target=outcome))
+                if len(list(nx.all_simple_paths(self.graph, source=cause, target=instrument))) > 0
+                and len(list(nx.all_simple_paths(self.graph, source=cause, target=outcome))) > 0
             )
         ):
             raise ValueError(f"Instrument {instrument} and outcome {outcome} share common causes")

Original file line number	Diff line number	Diff line change
`@@ -173,8 +173,8 @@ def check_iv_assumptions(self, treatment, outcome, instrument) -> bool:`
`173`	`173`	`(`
`174`	`174`	`cause`
`175`	`175`	`for cause in self.graph.nodes`
`176`		`- if list(nx.all_simple_paths(self.graph, source=cause, target=instrument))`
`177`		`- and list(nx.all_simple_paths(self.graph, source=cause, target=outcome))`
	`176`	`+ if len(list(nx.all_simple_paths(self.graph, source=cause, target=instrument))) > 0`
	`177`	`+ and len(list(nx.all_simple_paths(self.graph, source=cause, target=outcome))) > 0`
`178`	`178`	`)`
`179`	`179`	`):`
`180`	`180`	`raise ValueError(f"Instrument {instrument} and outcome {outcome} share common causes")`