Implement formula check in JSON frontend

Author: christopher-wild

causal_testing/json_front/json_class.py

@@ -270,6 +270,9 @@ def _execute_test_case(
         failed = False
 
         estimation_model = self._setup_test(causal_test_case=causal_test_case, test=test)
+        if "formula" in test:
+            if not estimation_model.validate_formula(self.causal_specification.causal_dag):
+                raise ValueError("Formula covariates do not satisfy the constructive back-door criterion.")
         causal_test_result = causal_test_case.execute_test(
             estimator=estimation_model, data_collector=self.data_collector
         )
@@ -331,6 +334,7 @@ def _setup_test(self, causal_test_case: CausalTestCase, test: Mapping) -> Estima
         estimator_kwargs["alpha"] = test["alpha"] if "alpha" in test else 0.05
 
         estimation_model = test["estimator"](**estimator_kwargs)
+
         return estimation_model
 
     def _append_to_file(self, line: str, log_level: int = None):

causal_testing/testing/estimators.py

@@ -105,6 +105,7 @@ def __init__(
 
         if formula is not None:
             self.formula = formula
+
         else:
             terms = [treatment] + sorted(list(adjustment_set)) + sorted(list(effect_modifiers))
             self.formula = f"{outcome} ~ {'+'.join(terms)}"
@@ -131,7 +132,7 @@ def get_terms_from_formula(self):
         return outcome, self.treatment, covariates
 
     def validate_formula(self, causal_dag: CausalDAG):
-        outcome, treatment, covariates = causal_dag.get_terms_from_formula()
+        outcome, treatment, covariates = self.get_terms_from_formula()
         proper_backdoor_graph = causal_dag.get_proper_backdoor_graph(treatments=[treatment], outcomes=[outcome])
         return CausalDAG.constructive_backdoor_criterion(proper_backdoor_graph=proper_backdoor_graph,
                                                          treatments=[treatment], outcomes=[outcome],