Skip to content

Commit 844849a

Browse files
Use pandas inbuilt assert_series_equal test instead of casting everything to single values
1 parent fb287ec commit 844849a

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

tests/testing_tests/test_causal_test_case.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ def test_execute_test_observational_causal_forest_estimator(self):
118118
self.df,
119119
)
120120
causal_test_result = self.causal_test_case.execute_test(estimation_model, self.data_collector)
121-
self.assertAlmostEqual(causal_test_result.test_value.value[0], 4, delta=1)
121+
pd.testing.assert_series_equal(causal_test_result.test_value.value, pd.Series(4.0), atol=1)
122122

123123
def test_invalid_causal_effect(self):
124124
"""Check that executing the causal test case returns the correct results for dummy data using a linear
@@ -140,7 +140,7 @@ def test_execute_test_observational_linear_regression_estimator(self):
140140
self.df,
141141
)
142142
causal_test_result = self.causal_test_case.execute_test(estimation_model, self.data_collector)
143-
self.assertAlmostEqual(causal_test_result.test_value.value[0], 4, delta=1e-10)
143+
pd.testing.assert_series_equal(causal_test_result.test_value.value, pd.Series(4.0), atol=1e-10)
144144

145145
def test_execute_test_observational_linear_regression_estimator_direct_effect(self):
146146
"""Check that executing the causal test case returns the correct results for dummy data using a linear
@@ -167,7 +167,7 @@ def test_execute_test_observational_linear_regression_estimator_direct_effect(se
167167
self.df,
168168
)
169169
causal_test_result = causal_test_case.execute_test(estimation_model, self.data_collector)
170-
self.assertAlmostEqual(causal_test_result.test_value.value[0], 4, delta=1e-10)
170+
pd.testing.assert_series_equal(causal_test_result.test_value.value, pd.Series(4.0), atol=1e-10)
171171

172172
def test_execute_test_observational_linear_regression_estimator_coefficient(self):
173173
"""Check that executing the causal test case returns the correct results for dummy data using a linear
@@ -182,7 +182,7 @@ def test_execute_test_observational_linear_regression_estimator_coefficient(self
182182
)
183183
self.causal_test_case.estimate_type = "coefficient"
184184
causal_test_result = self.causal_test_case.execute_test(estimation_model, self.data_collector)
185-
self.assertEqual(int(causal_test_result.test_value.value), 0)
185+
pd.testing.assert_series_equal(causal_test_result.test_value.value, pd.Series({'D': 0.0}), atol=1e-1)
186186

187187
def test_execute_test_observational_linear_regression_estimator_risk_ratio(self):
188188
"""Check that executing the causal test case returns the correct results for dummy data using a linear
@@ -197,7 +197,7 @@ def test_execute_test_observational_linear_regression_estimator_risk_ratio(self)
197197
)
198198
self.causal_test_case.estimate_type = "risk_ratio"
199199
causal_test_result = self.causal_test_case.execute_test(estimation_model, self.data_collector)
200-
self.assertEqual(int(causal_test_result.test_value.value), 0)
200+
pd.testing.assert_series_equal(causal_test_result.test_value.value, pd.Series(0.0), atol=1)
201201

202202
def test_invalid_estimate_type(self):
203203
"""Check that executing the causal test case returns the correct results for dummy data using a linear
@@ -227,7 +227,7 @@ def test_execute_test_observational_linear_regression_estimator_squared_term(sel
227227
formula=f"C ~ A + {'+'.join(self.minimal_adjustment_set)} + (D ** 2)",
228228
)
229229
causal_test_result = self.causal_test_case.execute_test(estimation_model, self.data_collector)
230-
self.assertAlmostEqual(round(causal_test_result.test_value.value[0], 1), 4, delta=1)
230+
pd.testing.assert_series_equal(causal_test_result.test_value.value, pd.Series(4.0), atol=1)
231231

232232
def test_execute_observational_causal_forest_estimator_cates(self):
233233
"""Check that executing the causal test case returns the correct conditional average treatment effects for

0 commit comments

Comments
 (0)