Pytest

Author: jmafoster1

causal_testing/testing/causal_test_outcome.py

@@ -32,9 +32,6 @@ def apply(self, res: CausalTestResult) -> bool:
             return (1 < res.ci_low() < res.ci_high()) or (res.ci_low() < res.ci_high() < 1)
         raise ValueError(f"Test Value type {res.test_value.type} is not valid for this TestOutcome")
 
-    def __str__(self):
-        return "Changed"
-
 
 class NoEffect(CausalTestOutcome):
     """An extension of TestOutcome representing that the expected causal effect should be zero."""
@@ -46,9 +43,6 @@ def apply(self, res: CausalTestResult) -> bool:
             return (res.ci_low() < 1 < res.ci_high()) or np.isclose(res.test_value.value, 1.0, atol=1e-10)
         raise ValueError(f"Test Value type {res.test_value.type} is not valid for this TestOutcome")
 
-    def __str__(self):
-        return "Unchanged"
-
 
 class ExactValue(SomeEffect):
     """An extension of TestOutcome representing that the expected causal effect should be a specific value."""
@@ -61,30 +55,33 @@ def __init__(self, value: float, tolerance: float = None):
             self.tolerance = tolerance
 
     def apply(self, res: CausalTestResult) -> bool:
-        super().apply()
+        if res.ci_valid():
+            return super().apply(res) and np.isclose(res.test_value.value, self.value, atol=self.tolerance)
         return np.isclose(res.test_value.value, self.value, atol=self.tolerance)
 
     def __str__(self):
         return f"ExactValue: {self.value}±{self.tolerance}"
 
 
-class Positive(SomeEffect):
+class Positive(CausalTestOutcome):
     """An extension of TestOutcome representing that the expected causal effect should be positive."""
 
     def apply(self, res: CausalTestResult) -> bool:
-        super().apply()
+        if res.ci_valid() and not super().apply(res):
+            return False
         if res.test_value.type == "ate":
             return res.test_value.value > 0
         if res.test_value.type == "risk_ratio":
             return res.test_value.value > 1
         raise ValueError(f"Test Value type {res.test_value.type} is not valid for this TestOutcome")
 
 
-class Negative(SomeEffect):
+class Negative(CausalTestOutcome):
     """An extension of TestOutcome representing that the expected causal effect should be negative."""
 
     def apply(self, res: CausalTestResult) -> bool:
-        super().apply()
+        if res.ci_valid() and not super().apply(res):
+            return False
         if res.test_value.type == "ate":
             return res.test_value.value < 0
         if res.test_value.type == "risk_ratio":

causal_testing/testing/causal_test_result.py

@@ -85,6 +85,10 @@ def ci_high(self):
             return max(self.confidence_intervals)
         return None
 
+    def ci_valid(self) -> bool:
+        """Return whether or not the result has valid confidence invervals"""
+        return self.ci_low() and self.ci_high()
+
     def summary(self):
         """Summarise the causal test result as an intuitive sentence."""
         print(

tests/testing_tests/test_causal_test_outcome.py

@@ -85,6 +85,17 @@ def test_Positive_fail(self):
         ev = Positive()
         self.assertFalse(ev.apply(ctr))
 
+    def test_Positive_fail_ci(self):
+        test_value = TestValue(type="ate", value=0)
+        ctr = CausalTestResult(
+            estimator=self.estimator,
+            test_value=test_value,
+            confidence_intervals=[-1, 1],
+            effect_modifier_configuration=None,
+        )
+        ev = Positive()
+        self.assertFalse(ev.apply(ctr))
+
     def test_Negative_pass(self):
         test_value = TestValue(type="ate", value=-5.05)
         ctr = CausalTestResult(
@@ -107,6 +118,17 @@ def test_Negative_fail(self):
         ev = Negative()
         self.assertFalse(ev.apply(ctr))
 
+    def test_Negative_fail_ci(self):
+        test_value = TestValue(type="ate", value=0)
+        ctr = CausalTestResult(
+            estimator=self.estimator,
+            test_value=test_value,
+            confidence_intervals=[-1, 1],
+            effect_modifier_configuration=None,
+        )
+        ev = Negative()
+        self.assertFalse(ev.apply(ctr))
+
     def test_exactValue_pass(self):
         test_value = TestValue(type="ate", value=5.05)
         ctr = CausalTestResult(