Addressed comments

Author: jmafoster1

causal_testing/testing/causal_test_engine.py

@@ -147,7 +147,7 @@ def _return_causal_test_results(self, estimator, causal_test_case):
         :return: a CausalTestResult object containing the confidence intervals
         """
         if not hasattr(estimator, f"estimate_{causal_test_case.estimate_type}"):
-            raise NotImplementedError(f"{estimator.__class__} has no {causal_test_case.estimate_type} method.")
+            raise AttributeError(f"{estimator.__class__} has no {causal_test_case.estimate_type} method.")
         estimate_effect = getattr(estimator, f"estimate_{causal_test_case.estimate_type}")
         effect, confidence_intervals = estimate_effect(**causal_test_case.estimate_params)
         causal_test_result = CausalTestResult(

causal_testing/testing/estimators.py

@@ -495,7 +495,7 @@ def add_modelling_assumptions(self):
             (iii) Instrument and outcome do not share causes
         """
 
-    def estimate_coefficient_aux(self, df):
+    def estimate_iv_coefficient(self, df):
         """
         Estimate the linear regression coefficient of the treatment on the
         outcome.
@@ -515,13 +515,13 @@ def estimate_coefficient(self, bootstrap_size=100):
         outcome.
         """
         bootstraps = sorted(
-            [self.estimate_coefficient_aux(self.df.sample(len(self.df), replace=True)) for _ in range(bootstrap_size)]
+            [self.estimate_iv_coefficient(self.df.sample(len(self.df), replace=True)) for _ in range(bootstrap_size)]
         )
         bound = ceil((bootstrap_size * self.alpha) / 2)
         ci_low = bootstraps[bound]
         ci_high = bootstraps[bootstrap_size - bound]
 
-        return self.estimate_coefficient_aux(self.df), (ci_low, ci_high)
+        return self.estimate_iv_coefficient(self.df), (ci_low, ci_high)
 
 
 class CausalForestEstimator(Estimator):

tests/testing_tests/test_causal_test_engine.py

@@ -220,7 +220,7 @@ def test_invalid_estimate_type(self):
             self.causal_test_engine.scenario_execution_data_df,
         )
         self.causal_test_case.estimate_type = "invalid"
-        with self.assertRaises(NotImplementedError):
+        with self.assertRaises(AttributeError):
             self.causal_test_engine.execute_test(estimation_model, self.causal_test_case)
 
     def test_execute_test_observational_linear_regression_estimator_squared_term(self):