Higher coverage

Author: jmafoster1

causal_testing/testing/causal_test_result.py

@@ -74,26 +74,22 @@ def to_dict(self):
             "adjustment_set": self.adjustment_set,
             "test_value": self.test_value,
         }
-        if self.confidence_intervals:
+        if self.confidence_intervals and all(self.confidence_intervals):
             base_dict["ci_low"] = min(self.confidence_intervals)
             base_dict["ci_high"] = max(self.confidence_intervals)
         return base_dict
 
     def ci_low(self):
         """Return the lower bracket of the confidence intervals."""
-        if not self.confidence_intervals:
-            return None
-        if any([x is None for x in self.confidence_intervals]):
-            return None
-        return min(self.confidence_intervals)
+        if self.confidence_intervals and all(self.confidence_intervals):
+            return min(self.confidence_intervals)
+        return None
 
     def ci_high(self):
         """Return the higher bracket of the confidence intervals."""
-        if not self.confidence_intervals:
-            return None
-        if any([x is None for x in self.confidence_intervals]):
-            return None
-        return max(self.confidence_intervals)
+        if self.confidence_intervals and all(self.confidence_intervals):
+            return max(self.confidence_intervals)
+        return None
 
     def summary(self):
         """Summarise the causal test result as an intuitive sentence."""

tests/testing_tests/test_causal_test_outcome.py

@@ -6,20 +6,51 @@
 class TestCausalTestOutcome(unittest.TestCase):
     """Test the TestCausalTestOutcome basic methods."""
 
+    def test_None_ci(self):
+        test_value = TestValue(type="ate", value=0)
+        ctr = CausalTestResult(
+            treatment="A",
+            outcome="A",
+            treatment_value=1,
+            control_value=0,
+            adjustment_set={},
+            test_value=test_value,
+            confidence_intervals=[None, None],
+            effect_modifier_configuration=None,
+        )
+
+        self.assertIsNone(ctr.ci_low())
+        self.assertIsNone(ctr.ci_high())
+        self.assertEqual(ctr.to_dict(),
+            {"treatment": "A",
+            "control_value": 0,
+            "treatment_value": 1,
+            "outcome": "A",
+            "adjustment_set": set(),
+            "test_value": test_value})
+
     def test_empty_adjustment_set(self):
+        test_value = TestValue(type="ate", value=0)
         ctr = CausalTestResult(
             treatment="A",
             outcome="A",
             treatment_value=1,
             control_value=0,
             adjustment_set={},
-            test_value=0,
+            test_value=test_value,
             confidence_intervals=None,
             effect_modifier_configuration=None,
         )
 
         self.assertIsNone(ctr.ci_low())
         self.assertIsNone(ctr.ci_high())
+        self.assertEqual(str(ctr), ("Causal Test Result\n==============\n"
+            "Treatment: A\n"
+            "Control value: 0\n"
+            "Treatment value: 1\n"
+            "Outcome: A\n"
+            "Adjustment set: set()\n"
+            "ate: 0\n" ))
 
     def test_exactValue_pass(self):
         test_value = TestValue(type="ate", value=5.05)
@@ -80,3 +111,20 @@ def test_someEffect_fail(self):
         )
         ev = SomeEffect()
         self.assertFalse(ev.apply(ctr))
+        self.assertEqual(str(ctr), ("Causal Test Result\n==============\n"
+            "Treatment: A\n"
+            "Control value: 0\n"
+            "Treatment value: 1\n"
+            "Outcome: A\n"
+            "Adjustment set: set()\n"
+            "ate: 0\n"
+            "Confidence intervals: [-0.1, 0.2]\n" ))
+        self.assertEqual(ctr.to_dict(),
+            {"treatment": "A",
+            "control_value": 0,
+            "treatment_value": 1,
+            "outcome": "A",
+            "adjustment_set": set(),
+            "test_value": test_value,
+            "ci_low": -0.1,
+            "ci_high": 0.2})