Pylint

Author: jmafoster1

causal_testing/__main__.py

@@ -29,6 +29,7 @@ def main() -> None:
             effect_type=args.effect_type,
             estimate_type=args.estimate_type,
             estimator=args.estimator,
+            skip=True,
         )
         logging.info("Causal test generation completed successfully")
         return

causal_testing/testing/metamorphic_relation.py

@@ -204,13 +204,7 @@ def generate_metamorphic_relations(
 
 
 def generate_causal_tests(
-    dag_path: str,
-    output_path: str,
-    ignore_cycles: bool = False,
-    threads: int = 0,
-    estimate_type: str = "coefficient",
-    effect_type: str = "direct",
-    estimator: str = "LinearRegressionEstimator",
+    dag_path: str, output_path: str, ignore_cycles: bool = False, threads: int = 0, **json_stub_kargs
 ):
     """
     Generate and output causal tests for a given DAG.
@@ -222,7 +216,7 @@ def generate_causal_tests(
                           be omitted from the test set.
     :param threads: The number of threads to use to generate tests in parallel. If unspecified, tests are generated in
                     serial. This is tylically fine unless the number of tests to be generated is >10000.
-    :param effect_type: The type of causal effect to consider (total or direct)
+    :param json_stub_kargs: Kwargs to pass into `to_json_stub` (see docstring for details.)
     :param estimate_type: The estimate type to use when evaluating tests
     :param estimator: The name of the estimator class to use when evaluating the test
     """
@@ -247,7 +241,7 @@ def generate_causal_tests(
         relations = generate_metamorphic_relations(causal_dag, nodes_to_test=dag_nodes_to_test, threads=threads)
 
     tests = [
-        relation.to_json_stub(skip=False, estimate_type=estimate_type, effect_type=effect_type, estimator=estimator)
+        relation.to_json_stub(**json_stub_kargs)
         for relation in relations
         if len(list(causal_dag.graph.predecessors(relation.base_test_case.outcome_variable))) > 0
     ]

tests/testing_tests/test_metamorphic_relations.py

@@ -120,7 +120,7 @@ def test_should_cause_logistic_json_stub(self):
         should_cause_mr = ShouldCause(BaseTestCase("X1", "Z"), adj_set)
         self.assertEqual(
             should_cause_mr.to_json_stub(
-                effect_type="total", estimate_type="unit_odds_ratio", estimator="LogisticRegressionEstimator"
+                effect_type="total", estimate_type="unit_odds_ratio", estimator="LogisticRegressionEstimator", skip=True
             ),
             {
                 "effect": "total",
@@ -263,7 +263,7 @@ def test_generate_causal_tests_ignore_cycles(self):
                 tests = json.load(f)
             expected = list(
                 map(
-                    lambda x: x.to_json_stub(skip=False),
+                    lambda x: x.to_json_stub(skip=True),
                     filter(
                         lambda relation: len(list(dcg.graph.predecessors(relation.base_test_case.outcome_variable)))
                         > 0,
@@ -283,7 +283,7 @@ def test_generate_causal_tests(self):
                 tests = json.load(f)
             expected = list(
                 map(
-                    lambda x: x.to_json_stub(skip=False),
+                    lambda x: x.to_json_stub(skip=True),
                     filter(
                         lambda relation: len(list(dag.graph.predecessors(relation.base_test_case.outcome_variable)))
                         > 0,