Skip to content

Commit ddb302d

Browse files
committed
Fixed silent and test failed
1 parent e676dc2 commit ddb302d

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

causal_testing/main.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -386,7 +386,7 @@ def run_tests(self, silent=False) -> List[CausalTestResult]:
386386
results.append(result)
387387
logger.info(f"Test completed: {test_case}")
388388
except Exception as e:
389-
if silent:
389+
if not silent:
390390
logger.error(f"Error running test {test_case}: {str(e)}")
391391
raise
392392
result = CausalTestResult(
@@ -424,7 +424,9 @@ def save_results(self, results: List[CausalTestResult]) -> None:
424424
ci_high = ci_high.tolist()
425425

426426
# Determine if test failed based on expected vs actual effect
427-
test_failed = not test_case.expected_causal_effect.apply(result)
427+
test_passed = (
428+
test_case.expected_causal_effect.apply(result) if result.test_value.type != "Error" else False
429+
)
428430

429431
output = {
430432
"name": test_config["name"],
@@ -435,7 +437,7 @@ def save_results(self, results: List[CausalTestResult]) -> None:
435437
"formula": test_config.get("formula"),
436438
"alpha": test_config.get("alpha", 0.05),
437439
"skip": test_config.get("skip", False),
438-
"failed": test_failed,
440+
"passed": test_passed,
439441
"result": {
440442
"treatment": result.estimator.base_test_case.treatment_variable.name,
441443
"outcome": result.estimator.base_test_case.outcome_variable.name,

0 commit comments

Comments
 (0)