Extra tests to make codecov happy

Author: jmafoster1

causal_testing/testing/causal_effect.py

@@ -114,8 +114,6 @@ class Positive(SomeEffect):
     Currently only single values are supported for the test value"""
 
     def apply(self, res: CausalTestResult) -> bool:
-        if res.ci_valid() and not super().apply(res):
-            return False
         if len(res.test_value.value) > 1:
             raise ValueError("Positive Effects are currently only supported on single float datatypes")
         if res.test_value.type in {"ate", "coefficient"}:
@@ -130,8 +128,6 @@ class Negative(SomeEffect):
     Currently only single values are supported for the test value"""
 
     def apply(self, res: CausalTestResult) -> bool:
-        if res.ci_valid() and not super().apply(res):
-            return False
         if len(res.test_value.value) > 1:
             raise ValueError("Negative Effects are currently only supported on single float datatypes")
         if res.test_value.type in {"ate", "coefficient"}:

tests/testing_tests/test_causal_effect.py

@@ -232,7 +232,7 @@ def test_invalid_ci_range(self):
 
     def test_invalid_ci_atol(self):
         with self.assertRaises(ValueError):
-            ExactValue(1000, ci_low=1001, ci_high=1002, atol=0.05)
+            ExactValue(1000, ci_low=999, ci_high=1001, atol=50)
 
     def test_invalid(self):
         test_value = TestValue(type="invalid", value=pd.Series(5.05))
@@ -295,6 +295,16 @@ def test_someEffect_fail(self):
         self.assertFalse(SomeEffect().apply(ctr))
         self.assertTrue(NoEffect().apply(ctr))
 
+    def test_someEffect_None(self):
+        test_value = TestValue(type="ate", value=pd.Series(0))
+        ctr = CausalTestResult(
+            estimator=self.estimator,
+            test_value=test_value,
+            confidence_intervals=None,
+            effect_modifier_configuration=None,
+        )
+        self.assertEquals(SomeEffect().apply(ctr), None)
+
     def test_someEffect_str(self):
         test_value = TestValue(type="ate", value=0)
         ctr = CausalTestResult(