Skip to content

Commit f0ca6a5

Browse files
committed
Fixed some comments from review
1 parent aaf49ed commit f0ca6a5

File tree

3 files changed

+4
-13
lines changed

3 files changed

+4
-13
lines changed

causal_testing/json_front/json_class.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -278,8 +278,6 @@ def _execute_test_case(
278278
if "coverage" in test and test["coverage"]:
279279
adequacy_metric = DataAdequacy(causal_test_case, estimation_model, self.data_collector)
280280
adequacy_metric.measure_adequacy()
281-
# self._append_to_file(f"KURTOSIS: {effect_estimate.mean()}", logging.INFO)
282-
# self._append_to_file(f"PASSING: {sum(outcomes)}/{len(outcomes)}", logging.INFO)
283281
causal_test_result.adequacy = adequacy_metric
284282

285283
if causal_test_result.ci_low() is not None and causal_test_result.ci_high() is not None:

causal_testing/testing/causal_test_outcome.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -58,12 +58,6 @@ def apply(self, res: CausalTestResult) -> bool:
5858
ci_high = res.ci_high() if isinstance(res.ci_high(), Iterable) else [res.ci_high()]
5959
value = res.test_value.value if isinstance(res.ci_high(), Iterable) else [res.test_value.value]
6060

61-
# if not all(ci_low < 0 < ci_high for ci_low, ci_high in zip(ci_low, ci_high)):
62-
# print(
63-
# "FAILING ON",
64-
# [(ci_low, ci_high) for ci_low, ci_high in zip(ci_low, ci_high) if not ci_low < 0 < ci_high],
65-
# )
66-
6761
return (
6862
sum(
6963
not ((ci_low < 0 < ci_high) or abs(v) < self.atol)

tests/testing_tests/test_causal_test_adequacy.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,10 @@
1717
from causal_testing.specification.causal_specification import CausalSpecification
1818

1919

20-
class TestJsonClass(unittest.TestCase):
21-
"""Test the JSON frontend for the Causal Testing Framework (CTF)
22-
23-
The JSON frontend is an alternative interface for the CTF where tests are specified in JSON format and ingested
24-
with the frontend. Tests involve testing that this correctly interfaces with the framework with some dummy data
20+
class TestCausalTestAdequacy(unittest.TestCase):
21+
"""
22+
Test the causal test adequacy metrics. These provide metrics determine how comprehensive a test set is and,
23+
ultimately whether we can stop testing.
2524
"""
2625

2726
def setUp(self) -> None:

0 commit comments

Comments
 (0)