remove showavailability parameter as its superseded by hidewhenrestricted

Author: dlandau

externallib.php

@@ -260,12 +260,6 @@ public static function add_lti_instance_parameters() {
                 VALUE_DEFAULT,
                 0
             ),
-            'showavailability' => new external_value(
-                PARAM_INT,
-                'Show availability info to students (0 or 1)',
-                VALUE_DEFAULT,
-                1
-            ),
             'hidewhenrestricted' => new external_value(
                 PARAM_INT,
                 'Hide activity when restricted (1) or show greyed-out (0)',
@@ -293,7 +287,6 @@ public static function add_lti_instance_parameters() {
      * @param int $launchcontainer Launch container
      * @param int $availablefrom Unix timestamp for availability start
      * @param int $availableuntil Unix timestamp for availability end
-     * @param int $showavailability Show availability info to students (0 or 1)
      * @param int $hidewhenrestricted Completely hide activity when date restrictions apply (1) or show greyed-out (0)
      * @return array LTI instance details
      */
@@ -314,7 +307,6 @@ public static function add_lti_instance(
         $launchcontainer = 1,
         $availablefrom = 0,
         $availableuntil = 0,
-        $showavailability = 1,
         $hidewhenrestricted = 0
     ) {
         global $DB, $CFG;
@@ -340,7 +332,6 @@ public static function add_lti_instance(
             'launchcontainer' => $launchcontainer,
             'availablefrom' => $availablefrom,
             'availableuntil' => $availableuntil,
-            'showavailability' => $showavailability,
             'hidewhenrestricted' => $hidewhenrestricted,
         ]);
 
@@ -721,12 +712,6 @@ public static function set_lti_availability_parameters() {
                 VALUE_DEFAULT,
                 0
             ),
-            'showavailability' => new external_value(
-                PARAM_INT,
-                'Show availability info to students (0 or 1)',
-                VALUE_DEFAULT,
-                1
-            ),
             'hidewhenrestricted' => new external_value(
                 PARAM_INT,
                 'Completely hide activity when restricted (1) or show greyed-out (0)',
@@ -741,15 +726,13 @@ public static function set_lti_availability_parameters() {
      * @param int $coursemoduleid Course module ID
      * @param int $availablefrom Unix timestamp for availability start
      * @param int $availableuntil Unix timestamp for availability end
-     * @param int $showavailability Show availability info to students (0 or 1)
      * @param int $hidewhenrestricted Completely hide activity when date restrictions apply (1) or show greyed-out (0)
      * @return array Update status
      */
     public static function set_lti_availability(
         $coursemoduleid,
         $availablefrom = 0,
         $availableuntil = 0,
-        $showavailability = 1,
         $hidewhenrestricted = 0
     ) {
         global $DB, $CFG;
@@ -762,7 +745,6 @@ public static function set_lti_availability(
             'coursemoduleid' => $coursemoduleid,
             'availablefrom' => $availablefrom,
             'availableuntil' => $availableuntil,
-            'showavailability' => $showavailability,
             'hidewhenrestricted' => $hidewhenrestricted,
         ]);