implement Chahan's review

Author: ValentinGebhart

CHANGELOG.md

@@ -28,7 +28,7 @@ Removed:
 - World Bank indicator data is now downloaded directly from their API via the function `download_world_bank_indicator`, instead of relying on the `pandas-datareader` package [#1033](https://github.com/CLIMADA-project/climada_python/pull/1033)
 - `Exposures.write_hdf5` pickles geometry data in WKB format, which is faster and more sustainable. [#1051](https://github.com/CLIMADA-project/climada_python/pull/1051)
 - The online documentation has been completely overhauled, now uses PyData theme: [#977](https://github.com/CLIMADA-project/climada_python/pull/977)
-- The default parameters of `impact_yearset`, `sample_events`, and `impact_yearset_from_sampling_vect` functions of the `climada.util.yearsets` module have been changed to sampling with replacement and not applying the correction factor to the impact yearsets. The application of the correction factor and the frequency of the resulting yearly impact object are corrected. [#1075](https://github.com/CLIMADA-project/climada_python/pull/1075)
+- The output of the `impact_yearset` was changed to only contain attributes corresponding to the yearly impact set. The default parameters of `impact_yearset`, `sample_events`, and `impact_yearset_from_sampling_vect` functions of the `climada.util.yearsets` module have been changed to sampling with replacement and not applying the correction factor to the impact yearsets. The application of the correction factor and the frequency of the resulting yearly impact object are corrected. [#1075](https://github.com/CLIMADA-project/climada_python/pull/1075)
 
 ### Fixed
 

climada/util/yearsets.py

@@ -123,6 +123,7 @@ def impact_yearset_from_sampling_vect(
 
     # compute impact per sampled_year
     imp_per_year = compute_imp_per_year(imp, sampling_vect)
+    frequency = np.ones(len(sampled_years)) / len(sampled_years)
 
     if correction_fac:  # adjust for sampling error
         correction_factor = calculate_correction_fac(imp_per_year, imp)
@@ -137,11 +138,11 @@ def impact_yearset_from_sampling_vect(
         event_id=np.arange(1, len(sampled_years) + 1),
         unit=imp.unit,
         haz_type=imp.haz_type,
-        frequency=np.ones(len(sampled_years)) / len(sampled_years),
+        frequency=frequency,
+        frequency_unit="1/year",
+        aai_agg=np.sum(frequency * imp_per_year),
     )
 
-    yimp.aai_agg = np.sum(yimp.frequency * yimp.at_event)
-
     return yimp