remove assign category

Author: NicolasColombi

climada/hazard/tc_tracks.py

@@ -1620,42 +1620,6 @@ def from_netcdf(cls, folder_name):
                 data.append(track)
         return cls(data)
 
-    @staticmethod
-    def define_tc_category_FAST(max_sust_wind: np.array, units: str = "kn") -> int:
-        """Define category of the tropical cyclone according to Saffir-Simpson scale.
-
-        Parameters:
-        ----------
-        max_wind : str
-            Maximal sustained wind speed
-        units: str
-            Wind speed units, kn or m/s. Default: kn
-
-        Returns:
-        -------
-        category : int
-           -1: "Tropical Depression",
-            0: "Tropical Storm",
-            1: "Hurricane Cat. 1",
-            2: "Hurricane Cat. 2",
-            3: "Hurricane Cat. 3",
-            4: "Hurricane Cat. 4",
-            5: "Hurricane Cat. 5",
-        """
-
-        max_sust_wind = max_sust_wind.astype(
-            float
-        )  # avoid casting errors if max_sust_wind is int
-        max_sust_wind *= 1.943844 if units == "m/s" else 1
-
-        max_wind = np.nanmax(max_sust_wind)
-        category_test = np.full(len(SAFFIR_SIM_CAT), max_wind) < np.array(
-            SAFFIR_SIM_CAT
-        )
-        category = np.argmax(category_test) - 1
-
-        return category
-
     @classmethod
     def from_FAST(cls, folder_name: str):
         """Create a new TCTracks object from NetCDF files generated by the FAST model, modifying
@@ -1707,13 +1671,13 @@ def from_FAST(cls, folder_name: str):
                             track.time.data, unit="s", origin=reference_time
                         ).astype("datetime64[s]")
                         # Define variables
-                        max_sustained_wind_knots = track.vmax_trks.data * 1.943844
+                        max_wind_kn = track.vmax_trks.data * 1.943844
                         env_pressure = BASIN_ENV_PRESSURE[track.tc_basins.data.item()]
                         cen_pres = _estimate_pressure(
                             np.full(lat.shape, np.nan),
                             lat,
                             lon,
-                            max_sustained_wind_knots,
+                            max_wind_kn,
                         )
 
                         data.append(
@@ -1758,8 +1722,8 @@ def from_FAST(cls, folder_name: str):
                                     "orig_event_flag": True,
                                     "data_provider": "FAST",
                                     "id_no": track.n_trk.item(),
-                                    "category": TCTracks.define_tc_category_FAST(
-                                        max_sustained_wind_knots
+                                    "category": set_category(
+                                        max_wind_kn, wind_unit="kn", saffir_scale=None
                                     ),
                                 },
                             )

climada/hazard/test/test_tc_tracks.py

@@ -632,17 +632,6 @@ def test_from_simulations_storm(self):
         tc_track = tc.TCTracks.from_simulations_storm(TEST_TRACK_STORM, years=[7])
         self.assertEqual(len(tc_track.data), 0)
 
-    def test_define_tc_category_FAST(self):
-        """test that the correct category is assigned to a TC from FAST model."""
-
-        max_wind = np.array([20, 72, 36, 50])  # knots
-        category1 = tc.TCTracks.define_tc_category_FAST(max_wind)
-        category2 = tc.TCTracks.define_tc_category_FAST(
-            max_sust_wind=max_wind, units="m/s"
-        )
-        self.assertEqual(category1, 1)
-        self.assertEqual(category2, 5)
-
     def test_from_FAST(self):
         """test the correct import of netcdf files from FAST model and the conversion to a
         different xr.array structure compatible with CLIMADA."""