rename from_fast and fix pylint to many locals

Author: NicolasColombi

climada/hazard/tc_tracks.py

@@ -1657,7 +1657,7 @@ def define_tc_category_fast(max_sust_wind: np.array, units: str = "kn") -> int:
         return category
 
     @classmethod
-    def from_fast(cls, folder_name: str):
+    def from_FAST(cls, folder_name: str):
         """Create a new TCTracks object from NetCDF files generated by the FAST model, modifying
         the xr.array structure to ensure compatibility with CLIMADA, and calculating the central
         pressure and radius of maximum wind.
@@ -1708,12 +1708,6 @@ def from_fast(cls, folder_name: str):
                     cen_pres = _estimate_pressure(
                         np.full(lat.shape, np.nan), lat, lon, max_sustained_wind_knots
                     )
-                    rmw = estimate_rmw(np.full(lat.shape, np.nan), cen_pres)
-
-                    # Define attributes
-                    category = TCTracks.define_tc_category_fast(
-                        max_sustained_wind_knots
-                    )
 
                     data.append(
                         xr.Dataset(
@@ -1724,7 +1718,10 @@ def from_fast(cls, folder_name: str):
                                 ),
                                 "max_sustained_wind": ("time", track.v_trks.data),
                                 "central_pressure": ("time", cen_pres),
-                                "radius_max_wind": ("time", rmw),
+                                "radius_max_wind": (
+                                    "time",
+                                    estimate_rmw(np.full(lat.shape, np.nan), cen_pres),
+                                ),
                                 "environmental_pressure": (
                                     "time",
                                     np.full(time.shape[0], env_pressure),
@@ -1742,12 +1739,14 @@ def from_fast(cls, folder_name: str):
                             attrs={
                                 "max_sustained_wind_unit": "m/s",
                                 "central_pressure_unit": "hPa",
-                                "name": "storm_%s" % track.n_trk.item(),
+                                "name": f"storm_{track.n_trk.item()}",
                                 "sid": track.n_trk.item(),
                                 "orig_event_flag": True,
                                 "data_provider": "FAST",
                                 "id_no": track.n_trk.item(),
-                                "category": category,
+                                "category": TCTracks.define_tc_category_fast(
+                                    max_sustained_wind_knots
+                                ),
                             },
                         )
                     )

climada/hazard/test/test_tc_tracks.py

@@ -644,11 +644,11 @@ def test_define_tc_category_fast(self):
         self.assertEqual(category1, 1)
         self.assertEqual(category2, 5)
 
-    def test_from_fast(self):
+    def test_from_FAST(self):
         """test the correct import of netcdf files from fast model and the conversion to a
         different xr.array structure compatible with CLIMADA."""
 
-        tc_track = tc.TCTracks.from_fast(TEST_TRACK_FAST)
+        tc_track = tc.TCTracks.from_FAST(TEST_TRACK_FAST)
 
         expected_attributes = {
             "max_sustained_wind_unit": "m/s",