Catch case where new Hazard fraction is unintentionally zero (#869)

* Catch case where new Hazard fraction is unintentionally zero
* Eliminate zeros in fraction matrix before selecting
* Update CHANGELOG.md

Author: peanutfun

CHANGELOG.md

@@ -17,6 +17,8 @@ Code freeze date: YYYY-MM-DD
 
 ### Fixed
 
+- Avoid an issue where a Hazard subselection would have a fraction matrix with only zeros as entries by throwing an error [#866](https://github.com/CLIMADA-project/climada_python/pull/866)
+
 ### Added
 
 - climada.hazard.centroids.centr.Centroids.get_area_pixel

climada/hazard/base.py

@@ -1197,6 +1197,10 @@ def select(self, event_names=None, event_id=None, date=None, orig=None,
             LOGGER.info('No hazard centroids within extent and region')
             return None
 
+        # Sanitize fraction, because we check non-zero entries later
+        self.fraction.eliminate_zeros()
+
+        # Perform attribute selection
         for (var_name, var_val) in self.__dict__.items():
             if isinstance(var_val, np.ndarray) and var_val.ndim == 1 \
                     and var_val.size > 0:
@@ -1227,6 +1231,18 @@ def select(self, event_names=None, event_id=None, date=None, orig=None,
                                    dt.datetime.fromordinal(haz.date.min()).year) + 1
             haz.frequency = haz.frequency * year_span_old / year_span_new
 
+        # Check if new fraction is zero everywhere
+        if self._get_fraction() is not None and haz._get_fraction() is None:
+            raise RuntimeError(
+                "Your selection created a Hazard object where the fraction matrix is "
+                "zero everywhere. This hazard will have zero impact everywhere. "
+                "We are catching this condition because of an implementation detail: "
+                "A fraction matrix without nonzero-valued entries will be completely "
+                "ignored. This is surely not what you intended. If you really want to, "
+                "you can circumvent this error by setting your original fraction "
+                "matrix to zero everywhere, but there probably is no point in doing so."
+            )
+
         haz.sanitize_event_ids()
         return haz
 

climada/hazard/test/test_base.py

@@ -595,6 +595,26 @@ def test_select_tight_pass(self):
         self.assertIsInstance(sel_haz.intensity, sparse.csr_matrix)
         self.assertIsInstance(sel_haz.fraction, sparse.csr_matrix)
 
+    def test_select_new_fraction_zero(self):
+        """Check if a new fraction of only zeros is handled correctly"""
+        hazard = dummy_hazard()
+        hazard.centroids.gdf["region_id"] = [1, 1, 2]
+
+        # Select a part of the hazard where fraction is zero only
+        with self.assertRaisesRegex(
+            RuntimeError,
+            "Your selection created a Hazard object where the fraction matrix is zero "
+            "everywhere"
+        ):
+            hazard.select(event_id=[3, 4], reg_id=[2])
+
+        # Error should not be thrown if we set everything to zero
+        # NOTE: Setting the values of `data` to zero instead of the matrix values will
+        #       add explicitly stored zeros. Therefore, this test explicitly checks if
+        #       `eliminate_zeros` is called on `fraction` during `select`.
+        hazard.fraction.data[...] = 0
+        selection = hazard.select(event_id=[3, 4], reg_id=[2])
+        np.testing.assert_array_equal(selection.fraction.toarray(), [[0], [0]])
 
 class TestAppend(unittest.TestCase):
     """Test append method."""