Add data shape check for ImpactForecast

Author: peanutfun

climada/engine/impact_forecast.py

@@ -51,8 +51,8 @@ def __init__(
         impact_kwargs
             Keyword-arguments passed to ~:py:class`climada.engine.impact.Impact`.
         """
-        # TODO: Maybe assert array lengths?
         super().__init__(lead_time=lead_time, member=member, **impact_kwargs)
+        self._check_shapes()
 
     @classmethod
     def from_impact(
@@ -88,3 +88,25 @@ def from_impact(
                 imp_mat=impact.imp_mat,
                 haz_type=impact.haz_type,
             )
+
+    def _check_shapes(self):
+        """Check shapes of forecast data vs. impact data.
+
+        Raises
+        ------
+        ValueError
+            If the shapes of the forecast data do not match the
+            :py:attr:`~climada.engine.impact.Impact.event_id`
+        """
+        shape_expected = self.event_id.shape
+
+        def check_forecast_attr(attr: str):
+            shape_actual = getattr(self, attr).shape
+            if shape_actual != shape_expected:
+                raise ValueError(
+                    f"Shape mismatch between Forecast.{attr} "
+                    f"{shape_actual} and Impact.event_id {shape_expected}"
+                )
+
+        check_forecast_attr("member")
+        check_forecast_attr("lead_time")

climada/engine/test/test_impact_forecast.py

@@ -76,6 +76,12 @@ def test_impact_forecast_init(self, impact_kwargs, lead_time, member):
         npt.assert_array_equal(forecast1.member, member)
         self.assert_impact_kwargs(forecast1, **impact_kwargs)
 
+    def test_impact_forecast_init_error(self, impact_kwargs, lead_time, member):
+        with pytest.raises(ValueError, match="Forecast.lead_time"):
+            ImpactForecast(lead_time=lead_time[:-2], member=member, **impact_kwargs)
+        with pytest.raises(ValueError, match="Forecast.member"):
+            ImpactForecast(lead_time=lead_time, member=member[1:], **impact_kwargs)
+
     def test_impact_forecast_from_impact(
         self, impact_forecast, impact_kwargs, lead_time, member
     ):