Fix phpGH-9921: Loading ext in FPM config does not register module handlers

bukka · bukka · commit a8c6c6165b9c · 2023-11-03T16:53:09.000Z
Closes phpGH-12377
diff --git a/NEWS b/NEWS
@@ -17,6 +17,8 @@ PHP                                                                        NEWS
   . Fixed bug GH-11121 (ReflectionFiber segfault). (danog, trowski, bwoebi)
 
 - FPM:
+  . Fixed bug GH-9921 (Loading ext in FPM config does not register module
+    handlers). (Jakub Zelenka)
   . Fixed bug GH-12232 (FPM: segfault dynamically loading extension without
     opcache). (Jakub Zelenka)
 
diff --git a/Zend/zend_API.c b/Zend/zend_API.c
@@ -2271,7 +2271,8 @@ ZEND_API void zend_collect_module_handlers(void) /* {{{ */
 			post_deactivate_count++;
 		}
 	} ZEND_HASH_FOREACH_END();
-	module_request_startup_handlers = (zend_module_entry**)malloc(
+	module_request_startup_handlers = (zend_module_entry**)realloc(
+		module_request_startup_handlers,
 	    sizeof(zend_module_entry*) *
 		(startup_count + 1 +
 		 shutdown_count + 1 +
@@ -2303,7 +2304,8 @@ ZEND_API void zend_collect_module_handlers(void) /* {{{ */
 		}
 	} ZEND_HASH_FOREACH_END();
 
-	class_cleanup_handlers = (zend_class_entry**)malloc(
+	class_cleanup_handlers = (zend_class_entry**)realloc(
+		class_cleanup_handlers,
 		sizeof(zend_class_entry*) *
 		(class_count + 1));
 	class_cleanup_handlers[class_count] = NULL;
@@ -2329,7 +2331,9 @@ ZEND_API void zend_startup_modules(void) /* {{{ */
 ZEND_API void zend_destroy_modules(void) /* {{{ */
 {
 	free(class_cleanup_handlers);
+	class_cleanup_handlers = NULL;
 	free(module_request_startup_handlers);
+	module_request_startup_handlers = NULL;
 	zend_hash_graceful_reverse_destroy(&module_registry);
 }
 /* }}} */
diff --git a/ext/dl_test/dl_test.c b/ext/dl_test/dl_test.c
@@ -69,6 +69,10 @@ PHP_MINIT_FUNCTION(dl_test)
 		REGISTER_INI_ENTRIES();
 	}
 
+	if (getenv("PHP_DL_TEST_MODULE_DEBUG")) {
+		fprintf(stderr, "DL TEST MINIT\n");
+	}
+
 	return SUCCESS;
 }
 /* }}} */
@@ -83,6 +87,10 @@ static PHP_MSHUTDOWN_FUNCTION(dl_test)
 		UNREGISTER_INI_ENTRIES();
 	}
 
+	if (getenv("PHP_DL_TEST_MODULE_DEBUG")) {
+		fprintf(stderr, "DL TEST MSHUTDOWN\n");
+	}
+
 	return SUCCESS;
 }
 /* }}} */
@@ -94,6 +102,21 @@ PHP_RINIT_FUNCTION(dl_test)
 	ZEND_TSRMLS_CACHE_UPDATE();
 #endif
 
+	if (getenv("PHP_DL_TEST_MODULE_DEBUG")) {
+		fprintf(stderr, "DL TEST RINIT\n");
+	}
+
+	return SUCCESS;
+}
+/* }}} */
+
+/* {{{ PHP_RSHUTDOWN_FUNCTION */
+PHP_RSHUTDOWN_FUNCTION(dl_test)
+{
+	if (getenv("PHP_DL_TEST_MODULE_DEBUG")) {
+		fprintf(stderr, "DL TEST RSHUTDOWN\n");
+	}
+
 	return SUCCESS;
 }
 /* }}} */
@@ -127,7 +150,7 @@ zend_module_entry dl_test_module_entry = {
 	PHP_MINIT(dl_test),
 	PHP_MSHUTDOWN(dl_test),
 	PHP_RINIT(dl_test),
-	NULL,
+	PHP_RSHUTDOWN(dl_test),
 	PHP_MINFO(dl_test),
 	PHP_DL_TEST_VERSION,
 	PHP_MODULE_GLOBALS(dl_test),
diff --git a/sapi/fpm/fpm/fpm_php.c b/sapi/fpm/fpm/fpm_php.c
@@ -77,6 +77,11 @@ static void fpm_php_disable(char *value, int (*zend_disable)(const char *, size_
 }
 /* }}} */
 
+#define FPM_PHP_INI_ALTERING_ERROR   -1
+#define FPM_PHP_INI_APPLIED          1
+#define FPM_PHP_INI_EXTENSION_FAILED 0
+#define FPM_PHP_INI_EXTENSION_LOADED 2
+
 int fpm_php_apply_defines_ex(struct key_value_s *kv, int mode) /* {{{ */
 {
 
@@ -90,45 +95,57 @@ int fpm_php_apply_defines_ex(struct key_value_s *kv, int mode) /* {{{ */
 		zend_interned_strings_switch_storage(0);
 		php_dl(value, MODULE_PERSISTENT, &zv, 1);
 		zend_interned_strings_switch_storage(1);
-		return Z_TYPE(zv) == IS_TRUE;
+		return Z_TYPE(zv) == IS_TRUE ? FPM_PHP_INI_EXTENSION_LOADED : FPM_PHP_INI_EXTENSION_FAILED;
 	}
 
 	if (fpm_php_zend_ini_alter_master(name, name_len, value, value_len, mode, PHP_INI_STAGE_ACTIVATE) == FAILURE) {
-		return -1;
+		return FPM_PHP_INI_ALTERING_ERROR;
 	}
 
 	if (!strcmp(name, "disable_functions") && *value) {
 		zend_disable_functions(value);
-		return 1;
+		return FPM_PHP_INI_APPLIED;
 	}
 
 	if (!strcmp(name, "disable_classes") && *value) {
 		char *v = strdup(value);
 		PG(disable_classes) = v;
 		fpm_php_disable(v, zend_disable_class);
-		return 1;
+		return FPM_PHP_INI_APPLIED;
 	}
 
-	return 1;
+	return FPM_PHP_INI_APPLIED;
 }
 /* }}} */
 
 static int fpm_php_apply_defines(struct fpm_worker_pool_s *wp) /* {{{ */
 {
 	struct key_value_s *kv;
+	int apply_result;
+	bool extension_loaded = false;
 
 	for (kv = wp->config->php_values; kv; kv = kv->next) {
-		if (fpm_php_apply_defines_ex(kv, ZEND_INI_USER) == -1) {
+		apply_result = fpm_php_apply_defines_ex(kv, ZEND_INI_USER);
+		if (apply_result == FPM_PHP_INI_ALTERING_ERROR) {
 			zlog(ZLOG_ERROR, "Unable to set php_value '%s'", kv->key);
+		} else if (apply_result == FPM_PHP_INI_EXTENSION_LOADED) {
+			extension_loaded = true;
 		}
 	}
 
 	for (kv = wp->config->php_admin_values; kv; kv = kv->next) {
-		if (fpm_php_apply_defines_ex(kv, ZEND_INI_SYSTEM) == -1) {
+		apply_result = fpm_php_apply_defines_ex(kv, ZEND_INI_SYSTEM);
+		if (apply_result == FPM_PHP_INI_ALTERING_ERROR) {
 			zlog(ZLOG_ERROR, "Unable to set php_admin_value '%s'", kv->key);
+		} else if (apply_result == FPM_PHP_INI_EXTENSION_LOADED) {
+			extension_loaded = true;
 		}
 	}
 
+	if (extension_loaded) {
+		zend_collect_module_handlers();
+	}
+
 	return 0;
 }
 /* }}} */
diff --git a/sapi/fpm/tests/gh9921-php-value-ext-mod-handlers.phpt b/sapi/fpm/tests/gh9921-php-value-ext-mod-handlers.phpt
@@ -0,0 +1,54 @@
+--TEST--
+FPM: GH-9921 - loading shared ext in FPM config does not register module handlers
+--SKIPIF--
+<?php
+include "skipif.inc";
+FPM\Tester::skipIfSharedExtensionNotFound('dl_test');
+?>
+--FILE--
+<?php
+
+require_once "tester.inc";
+
+$cfg = <<<EOT
+[global]
+error_log = {{FILE:LOG}}
+[unconfined]
+listen = {{ADDR}}
+pm = static
+pm.max_children = 1
+pm.status_path = /status
+catch_workers_output = yes
+env[PHP_DL_TEST_MODULE_DEBUG] = 1
+php_admin_value[extension] = dl_test
+EOT;
+
+$code = <<<EOT
+<?php
+var_dump(extension_loaded('dl_test'));
+EOT;
+
+$tester = new FPM\Tester($cfg, $code);
+$tester->start();
+$tester->expectLogStartNotices();
+$tester->request()->expectBody('bool(true)');
+$tester->expectLogPattern('/DL TEST MINIT/');
+$tester->expectLogPattern('/DL TEST RINIT/');
+$tester->expectLogPattern('/DL TEST RSHUTDOWN/');
+$tester->request()->expectBody('bool(true)');
+$tester->expectLogPattern('/DL TEST RINIT/');
+$tester->expectLogPattern('/DL TEST RSHUTDOWN/');
+$tester->terminate();
+$tester->expectLogTerminatingNotices();
+$tester->close();
+
+?>
+Done
+--EXPECT--
+Done
+--CLEAN--
+<?php
+require_once "tester.inc";
+FPM\Tester::clean();
+?>
+<?php

Original file line number	Diff line number	Diff line change
`@@ -77,6 +77,11 @@ static void fpm_php_disable(char value, int (zend_disable)(const char *, size_`
`77`	`77`	`}`
`78`	`78`	`/* }}} */`
`79`	`79`
	`80`	`+#define FPM_PHP_INI_ALTERING_ERROR -1`
	`81`	`+#define FPM_PHP_INI_APPLIED 1`
	`82`	`+#define FPM_PHP_INI_EXTENSION_FAILED 0`
	`83`	`+#define FPM_PHP_INI_EXTENSION_LOADED 2`
	`84`	`+`
`80`	`85`	`int fpm_php_apply_defines_ex(struct key_value_s kv, int mode) / {{{ */`
`81`	`86`	`{`
`82`	`87`
`@@ -90,45 +95,57 @@ int fpm_php_apply_defines_ex(struct key_value_s kv, int mode) / {{{ */`
`90`	`95`	`zend_interned_strings_switch_storage(0);`
`91`	`96`	`php_dl(value, MODULE_PERSISTENT, &zv, 1);`
`92`	`97`	`zend_interned_strings_switch_storage(1);`
`93`		`- return Z_TYPE(zv) == IS_TRUE;`
	`98`	`+ return Z_TYPE(zv) == IS_TRUE ? FPM_PHP_INI_EXTENSION_LOADED : FPM_PHP_INI_EXTENSION_FAILED;`
`94`	`99`	`}`
`95`	`100`
`96`	`101`	`if (fpm_php_zend_ini_alter_master(name, name_len, value, value_len, mode, PHP_INI_STAGE_ACTIVATE) == FAILURE) {`
`97`		`- return -1;`
	`102`	`+ return FPM_PHP_INI_ALTERING_ERROR;`
`98`	`103`	`}`
`99`	`104`
`100`	`105`	`if (!strcmp(name, "disable_functions") && *value) {`
`101`	`106`	`zend_disable_functions(value);`
`102`		`- return 1;`
	`107`	`+ return FPM_PHP_INI_APPLIED;`
`103`	`108`	`}`
`104`	`109`
`105`	`110`	`if (!strcmp(name, "disable_classes") && *value) {`
`106`	`111`	`char *v = strdup(value);`
`107`	`112`	`PG(disable_classes) = v;`
`108`	`113`	`fpm_php_disable(v, zend_disable_class);`
`109`		`- return 1;`
	`114`	`+ return FPM_PHP_INI_APPLIED;`
`110`	`115`	`}`
`111`	`116`
`112`		`- return 1;`
	`117`	`+ return FPM_PHP_INI_APPLIED;`
`113`	`118`	`}`
`114`	`119`	`/* }}} */`
`115`	`120`
`116`	`121`	`static int fpm_php_apply_defines(struct fpm_worker_pool_s wp) / {{{ */`
`117`	`122`	`{`
`118`	`123`	`struct key_value_s *kv;`
	`124`	`+ int apply_result;`
	`125`	`+ bool extension_loaded = false;`
`119`	`126`
`120`	`127`	`for (kv = wp->config->php_values; kv; kv = kv->next) {`
`121`		`- if (fpm_php_apply_defines_ex(kv, ZEND_INI_USER) == -1) {`
	`128`	`+ apply_result = fpm_php_apply_defines_ex(kv, ZEND_INI_USER);`
	`129`	`+ if (apply_result == FPM_PHP_INI_ALTERING_ERROR) {`
`122`	`130`	`zlog(ZLOG_ERROR, "Unable to set php_value '%s'", kv->key);`
	`131`	`+ } else if (apply_result == FPM_PHP_INI_EXTENSION_LOADED) {`
	`132`	`+ extension_loaded = true;`
`123`	`133`	`}`
`124`	`134`	`}`
`125`	`135`
`126`	`136`	`for (kv = wp->config->php_admin_values; kv; kv = kv->next) {`
`127`		`- if (fpm_php_apply_defines_ex(kv, ZEND_INI_SYSTEM) == -1) {`
	`137`	`+ apply_result = fpm_php_apply_defines_ex(kv, ZEND_INI_SYSTEM);`
	`138`	`+ if (apply_result == FPM_PHP_INI_ALTERING_ERROR) {`
`128`	`139`	`zlog(ZLOG_ERROR, "Unable to set php_admin_value '%s'", kv->key);`
	`140`	`+ } else if (apply_result == FPM_PHP_INI_EXTENSION_LOADED) {`
	`141`	`+ extension_loaded = true;`
`129`	`142`	`}`
`130`	`143`	`}`
`131`	`144`
	`145`	`+ if (extension_loaded) {`
	`146`	`+ zend_collect_module_handlers();`
	`147`	`+ }`
	`148`	`+`
`132`	`149`	`return 0;`
`133`	`150`	`}`
`134`	`151`	`/* }}} */`