cron/Workplace: move status check to MakeOperator()

Author: MaxKellermann

debian/changelog

@@ -1,6 +1,6 @@
 cm4all-workshop (6.10) unstable; urgency=low
 
-  * 
+  * cron: check the translation status for HTTP jobs
 
  --   
 

src/cron/Workplace.cxx

@@ -177,6 +177,8 @@ MakeSpawnOperator(EventLoop &event_loop, SpawnService &spawn_service,
 		  const CronJob &job, const char *command,
 		  const TranslateResponse &response)
 {
+	assert(response.status == HttpStatus{});
+
 	/* prepare the child process */
 
 	FdHolder close_fds;
@@ -188,16 +190,6 @@ MakeSpawnOperator(EventLoop &event_loop, SpawnService &spawn_service,
 		p.args.push_back(command);
 	}
 
-	if (response.status != HttpStatus{}) {
-		if (response.message != nullptr)
-			throw FmtRuntimeError("Status {} from translation server: {}",
-					      static_cast<unsigned>(response.status),
-					      response.message);
-
-		throw FmtRuntimeError("Status {} from translation server",
-				      static_cast<unsigned>(response.status));
-	}
-
 	if (response.child_options.uid_gid.IsEmpty() && !debug_mode)
 		throw std::runtime_error("No UID_GID from translation server");
 
@@ -268,6 +260,16 @@ CronWorkplace::Running::MakeOperator(SocketAddress translation_socket,
 		std::throw_with_nested(std::runtime_error("Translation failed"));
 	}
 
+	if (response.status != HttpStatus{}) {
+		if (response.message != nullptr)
+			throw FmtRuntimeError("Status {} from translation server: {}",
+					      static_cast<unsigned>(response.status),
+					      response.message);
+
+		throw FmtRuntimeError("Status {} from translation server",
+				      static_cast<unsigned>(response.status));
+	}
+
 	if (response.site != nullptr)
 		site = response.site;