Improve library linking

* Use private links for libraries that are specific to one module
* Separate linking of Boost::python and Boost::iostreams
* Remove explicit links to private libraries in exported cmake config

Author: arahlin

CMakeLists.txt

@@ -66,7 +66,7 @@ endif()
 
 target_compile_features(spt3g INTERFACE cxx_std_17)
 target_include_directories(spt3g INTERFACE ${Boost_INCLUDE_DIR})
-target_link_libraries(spt3g INTERFACE Threads::Threads ${Boost_LIBRARIES})
+target_link_libraries(spt3g INTERFACE Threads::Threads Boost::python)
 target_include_directories(spt3g INTERFACE $<INSTALL_INTERFACE:${SPT3G_INCLUDE_INSTALL_DIR}>)
 
 # Python bindings

cmake/Spt3gConfig.cmake.in

@@ -42,17 +42,7 @@ set(Boost_USE_STATIC_LIBS @Boost_USE_STATIC_LIBS@)
 set(Boost_USE_MULTITHREADED @Boost_USE_MULTITHREADED@)
 set(Boost_USE_STATIC_RUNTIME @Boost_USE_STATIC_RUNTIME@)
 set(Boost_PYTHON_VERSION @Boost_PYTHON_VERSION@)
-find_dependency(Boost COMPONENTS iostreams python REQUIRED)
-
-if(@FLAC_FOUND@)
-	find_dependency(FLAC MODULE)
-endif()
-if(@NetCDF_FOUND@)
-	find_dependency(NetCDF MODULE)
-endif()
-if(@OpenMP_FOUND@)
-	find_dependency(OpenMP)
-endif()
+find_dependency(Boost COMPONENTS python REQUIRED)
 
 include(FindPackageHandleStandardArgs)
 find_package_handle_standard_args(Spt3g

core/CMakeLists.txt

@@ -22,7 +22,7 @@ add_spt3g_library(core SHARED
 target_link_libraries(core PUBLIC spt3g)
 
 find_package(Filesystem REQUIRED)
-target_link_libraries(core PUBLIC std::filesystem)
+target_link_libraries(core PRIVATE std::filesystem)
 
 # add python bindings
 add_spt3g_module(core src/python.cxx)
@@ -37,10 +37,12 @@ target_include_directories(core PUBLIC
 find_package(FLAC MODULE)
 if(FLAC_FOUND)
 	target_compile_definitions(core PRIVATE -DG3_HAS_FLAC)
-	target_link_libraries(core PUBLIC FLAC::FLAC)
-	set(FLAC_FOUND ${FLAC_FOUND} PARENT_SCOPE)
+	target_link_libraries(core PRIVATE FLAC::FLAC)
 endif()
 
+# Link Boost IOStreams
+target_link_libraries(core PRIVATE Boost::iostreams)
+
 # Link against BZIP2 library
 if(NOT DEFINED WITH_BZIP2)
 	set(WITH_BZIP2 TRUE CACHE BOOL "Enable bzip2 file compression")

dfmux/CMakeLists.txt

@@ -17,9 +17,8 @@ target_link_libraries(dfmux PUBLIC core)
 add_spt3g_module(dfmux src/python.cxx)
 
 if (NetCDF_FOUND AND HDF5_FOUND)
-	target_link_libraries(dfmux PUBLIC NetCDF::NetCDF)
+	target_link_libraries(dfmux PRIVATE NetCDF::NetCDF)
 	add_spt3g_program(bin/ledgerman.py ledgerman)
-	set(NetCDF_FOUND ${NetCDF_FOUND} PARENT_SCOPE)
 endif()
 
 link_python_dir()

maps/CMakeLists.txt

@@ -22,8 +22,7 @@ target_link_libraries(maps PUBLIC core calibration)
 
 find_package(OpenMP)
 if(OpenMP_FOUND)
-  target_link_libraries(maps PUBLIC OpenMP::OpenMP_CXX)
-  set(OpenMP_FOUND ${OpenMP_FOUND} PARENT_SCOPE)
+  target_link_libraries(maps PRIVATE OpenMP::OpenMP_CXX)
 endif()
 
 add_spt3g_module(maps src/python.cxx)