Another compiler warning for boost python object extraction

Author: arahlin

dfmux/src/DfMuxCollector.cxx

@@ -406,27 +406,35 @@ make_dfmux_collector_v2_from_dict(const char *listenaddr,
 	for (ssize_t i = 0; i < bp::len(items); i++) {
 		int32_t serial = bp::extract<int>(items[i][1])();
 		in_addr_t ip;
+		bool found = false;
 
-		if (bp::extract<int>(items[i][0]).check()) {
-			ip = bp::extract<int>(items[i][0])();
-		} else if (bp::extract<std::string>(items[i][0]).check()) {
-			std::string host = bp::extract<std::string>(
-			    items[i][0])();
-			struct addrinfo hints, *info;
-			int err;
-
-			bzero(&hints, sizeof(hints));
-			hints.ai_family = PF_INET;
-			
-			err = getaddrinfo(host.c_str(), NULL, &hints, &info);
-			if (err != 0)
-				log_fatal("Could not find host %s (%s)",
-				    host.c_str(), gai_strerror(err));
-
-			g3_assert(info->ai_family == PF_INET);
-			ip = ((struct sockaddr_in *)(info->ai_addr))->
-			    sin_addr.s_addr;
+		auto int_item = bp::extract<int>(items[i][0]);
+		if (int_item.check()) {
+			ip = int_item();
+			found = true;
 		} else {
+			auto str_item = bp::extract<std::string>(items[i][0]);
+			if (str_item.check()) {
+				std::string host = str_item();
+				struct addrinfo hints, *info;
+				int err;
+
+				bzero(&hints, sizeof(hints));
+				hints.ai_family = PF_INET;
+
+				err = getaddrinfo(host.c_str(), NULL, &hints, &info);
+				if (err != 0)
+					log_fatal("Could not find host %s (%s)",
+					    host.c_str(), gai_strerror(err));
+
+				g3_assert(info->ai_family == PF_INET);
+				ip = ((struct sockaddr_in *)(info->ai_addr))->
+				    sin_addr.s_addr;
+
+				found = true;
+			}
+		}
+		if (!found) {
 			log_fatal("Map keys must be integer or string "
 			    "representations of the IP address or hostname");
 		}