forked from rectorphp/rector-symfony
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathServiceSettersToSettersAutodiscoveryRector.php
More file actions
248 lines (198 loc) · 7.87 KB
/
ServiceSettersToSettersAutodiscoveryRector.php
File metadata and controls
248 lines (198 loc) · 7.87 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
<?php
declare(strict_types=1);
namespace Rector\Symfony\Configs\Rector\Closure;
use PhpParser\Node;
use PhpParser\Node\Arg;
use PhpParser\Node\Expr\BinaryOp\Concat;
use PhpParser\Node\Expr\ClassConstFetch;
use PhpParser\Node\Expr\Closure;
use PhpParser\Node\Expr\ConstFetch;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Expr\Variable;
use PhpParser\Node\Name;
use PhpParser\Node\Scalar\String_;
use PhpParser\Node\Stmt;
use PhpParser\Node\Stmt\Expression;
use PHPStan\Reflection\ReflectionProvider;
use PHPStan\Type\ObjectType;
use Rector\Exception\ShouldNotHappenException;
use Rector\PhpParser\Node\Value\ValueResolver;
use Rector\Rector\AbstractRector;
use Rector\Symfony\MinimalSharedStringSolver;
use Rector\Symfony\NodeAnalyzer\SymfonyPhpClosureDetector;
use Rector\Symfony\ValueObject\ClassNameAndFilePath;
use Symfony\Component\Filesystem\Filesystem;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Symfony\Tests\Configs\Rector\Closure\ServiceSettersToSettersAutodiscoveryRector\ServiceSettersToSettersAutodiscoveryRectorTest
*/
final class ServiceSettersToSettersAutodiscoveryRector extends AbstractRector
{
private readonly MinimalSharedStringSolver $minimalSharedStringSolver;
public function __construct(
private readonly SymfonyPhpClosureDetector $symfonyPhpClosureDetector,
private readonly ReflectionProvider $reflectionProvider,
private readonly Filesystem $filesystem,
private readonly ValueResolver $valueResolver,
) {
$this->minimalSharedStringSolver = new MinimalSharedStringSolver();
}
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition('Change $services->set(..., ...) to $services->load(..., ...) where meaningful', [
new CodeSample(
<<<'CODE_SAMPLE'
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
use App\Services\FistService;
use App\Services\SecondService;
return static function (ContainerConfigurator $containerConfigurator): void {
$parameters = $containerConfigurator->parameters();
$services = $containerConfigurator->services();
$services->set(FistService::class);
$services->set(SecondService::class);
};
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
return static function (ContainerConfigurator $containerConfigurator): void {
$parameters = $containerConfigurator->parameters();
$services = $containerConfigurator->services();
$services->load('App\\Services\\', '../src/Services/*');
};
CODE_SAMPLE
),
]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return [Closure::class];
}
/**
* @param Closure $node
*/
public function refactor(Node $node): ?Node
{
if (! $this->symfonyPhpClosureDetector->detect($node)) {
return null;
}
/** @var array<Expression<MethodCall>> $bareServicesSetMethodCallExpressions */
$bareServicesSetMethodCallExpressions = $this->collectServiceSetMethodCallExpressions($node);
if ($bareServicesSetMethodCallExpressions === []) {
return null;
}
$classNamesAndFilesPaths = $this->createClassNamesAndFilePaths($bareServicesSetMethodCallExpressions);
$classNames = array_map(
fn (ClassNameAndFilePath $classNameAndFilePath): string => $classNameAndFilePath->getClassName(),
$classNamesAndFilesPaths
);
$sharedNamespace = $this->minimalSharedStringSolver->solve(...$classNames);
$firstClassNameAndFilePath = $classNamesAndFilesPaths[0];
$classFilePath = $firstClassNameAndFilePath->getFilePath();
$directoryConcat = $this->createAbsolutePathConcat($classFilePath);
$loadMethodCall = $this->createServicesLoadMethodCall($sharedNamespace, $directoryConcat);
$node->stmts[] = new Expression($loadMethodCall);
$this->removeServicesSetMethodCalls($node, $bareServicesSetMethodCallExpressions);
return $node;
}
public function isBareServicesSetMethodCall(MethodCall $methodCall): bool
{
if (! $this->isName($methodCall->name, 'set')) {
return false;
}
if (! $this->isObjectType(
$methodCall->var,
new ObjectType('Symfony\Component\DependencyInjection\Loader\Configurator\ServicesConfigurator')
)) {
return false;
}
// must have exactly single argument
if (count($methodCall->getArgs()) !== 1) {
return false;
}
$firstArg = $methodCall->getArgs()[0];
// first argument must be a class name, e.g. SomeClass::class
return $firstArg->value instanceof ClassConstFetch;
}
/**
* @return array<Expression<MethodCall>>
*/
private function collectServiceSetMethodCallExpressions(Closure $closure): array
{
$servicesSetMethodCalls = [];
foreach ($closure->stmts as $stmt) {
if (! $stmt instanceof Expression) {
continue;
}
if (! $stmt->expr instanceof MethodCall) {
continue;
}
$methodCall = $stmt->expr;
if (! $this->isBareServicesSetMethodCall($methodCall)) {
continue;
}
$servicesSetMethodCalls[] = $stmt;
}
return $servicesSetMethodCalls;
}
/**
* @param array<Expression<MethodCall>> $methodsCallExpressions
* @return ClassNameAndFilePath[]
*/
private function createClassNamesAndFilePaths(array $methodsCallExpressions): array
{
$classNamesAndFilesPaths = [];
foreach ($methodsCallExpressions as $methodCallExpression) {
/** @var MethodCall $methodCall */
$methodCall = $methodCallExpression->expr;
$firstArg = $methodCall->getArgs()[0];
$serviceClassReference = $this->valueResolver->getValue($firstArg->value);
if (! is_string($serviceClassReference)) {
throw new ShouldNotHappenException();
}
$classReflection = $this->reflectionProvider->getClass($serviceClassReference);
// we only work with known local classes
if ($classReflection->isInternal()) {
continue;
}
$filename = $classReflection->getFileName();
if (! is_string($filename)) {
continue;
}
$classNamesAndFilesPaths[] = new ClassNameAndFilePath($classReflection->getName(), $filename);
}
return $classNamesAndFilesPaths;
}
private function createAbsolutePathConcat(string $classFilePath): Concat
{
$relativeDirectoryPath = $this->filesystem->makePathRelative(
dirname($classFilePath),
dirname($this->file->getFilePath())
);
$distConstFetch = new ConstFetch(new Name('__DIR__'));
return new Concat($distConstFetch, new String_('/' . $relativeDirectoryPath));
}
private function createServicesLoadMethodCall(string $sharedNamespace, Concat $directoryConcat): MethodCall
{
$args = [new Arg(new String_($sharedNamespace)), new Arg($directoryConcat)];
return new MethodCall(new Variable('services'), 'load', $args);
}
/**
* @param Stmt[] $stmtsToRemove
*/
private function removeServicesSetMethodCalls(Closure $closure, array $stmtsToRemove): void
{
foreach ($closure->stmts as $key => $stmt) {
foreach ($stmtsToRemove as $stmtToRemove) {
if ($stmt === $stmtToRemove) {
unset($closure->stmts[$key]);
continue 2;
}
}
}
}
}