Apply suggestion from @Copilot - Adding error handling on async requests

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: cheinrichs-oddball

apps/it-governance/web-resources/js/openProgressToNewStepModal.js

@@ -10,53 +10,69 @@ async function openActivityLogQuickCreate(primaryControl) {
     return;
   }
 
-  const parentId = parentIdRaw.replace(/[{}]/g, "");
-  const parentName =
-    formContext.data.entity.getPrimaryAttributeValue?.() || "Admin Review";
-
-  const parent = await Xrm.WebApi.retrieveRecord(
-    parentEntityName,
-    parentId,
-    "?$select=_cr69a_systemintake_value",
-  );
-
-  const systemIntakeId = parent?._cr69a_systemintake_value;
-  const systemIntakeName =
-    parent?.[
-      "_cr69a_systemintake_value@OData.Community.Display.V1.FormattedValue"
-    ];
-
-  const parameters = {
-    new_adminreview: parentId,
-    new_adminreviewname: parentName,
-    new_adminreviewtype: parentEntityName,
-  };
-
-  if (systemIntakeId) {
-    parameters.new_systemintake = systemIntakeId;
-    parameters.new_systemintakename = systemIntakeName || "System Intake";
-    parameters.new_systemintaketype = "new_systemintake";
-  }
+  try {
+    const parentId = parentIdRaw.replace(/[{}]/g, "");
+    const parentName =
+      formContext.data.entity.getPrimaryAttributeValue?.() || "Admin Review";
+
+    const parent = await Xrm.WebApi.retrieveRecord(
+      parentEntityName,
+      parentId,
+      "?$select=_cr69a_systemintake_value",
+    );
+
+    const systemIntakeId = parent?._cr69a_systemintake_value;
+    const systemIntakeName =
+      parent?.[
+        "_cr69a_systemintake_value@OData.Community.Display.V1.FormattedValue"
+      ];
+
+    const parameters = {
+      new_adminreview: parentId,
+      new_adminreviewname: parentName,
+      new_adminreviewtype: parentEntityName,
+    };
+
+    if (systemIntakeId) {
+      parameters.new_systemintake = systemIntakeId;
+      parameters.new_systemintakename = systemIntakeName || "System Intake";
+      parameters.new_systemintaketype = "new_systemintake";
+    }
+
+    // ✅ Prefill Activity By (current user)
+    const ctx = Xrm.Utility.getGlobalContext();
+    const currentUserId = (ctx.userSettings.userId || "").replace(/[{}]/g, "");
+    const currentUserName = ctx.userSettings.userName || "Current User";
 
-  // ✅ Prefill Activity By (current user)
-  const ctx = Xrm.Utility.getGlobalContext();
-  const currentUserId = (ctx.userSettings.userId || "").replace(/[{}]/g, "");
-  const currentUserName = ctx.userSettings.userName || "Current User";
+    parameters.new_activityby = currentUserId;
+    parameters.new_activitybyname = currentUserName;
+    parameters.new_activitybytype = "systemuser";
 
-  parameters.new_activityby = currentUserId;
-  parameters.new_activitybyname = currentUserName;
-  parameters.new_activitybytype = "systemuser";
+    parameters.new_activityon = new Date();
 
-  parameters.new_activityon = new Date();
+    const formOptions = {
+      entityName: "new_activitylogs",
+      useQuickCreateForm: true,
+    };
 
-  const formOptions = {
-    entityName: "new_activitylogs",
-    useQuickCreateForm: true,
-  };
+    const result = await Xrm.Navigation.openForm(formOptions, parameters);
 
-  const result = await Xrm.Navigation.openForm(formOptions, parameters);
+    if (result && result.savedEntityReference) {
+      await formContext.data.refresh(true);
+    }
+  } catch (error) {
+    const message =
+      "An error occurred while opening the Activity Log quick create form. Please try again or contact your system administrator.";
 
-  if (result && result.savedEntityReference) {
-    await formContext.data.refresh(true);
+    if (Xrm?.Navigation?.openErrorDialog) {
+      await Xrm.Navigation.openErrorDialog({
+        message,
+        details: (error && (error.message || error.toString())) || undefined,
+      });
+    } else if (Xrm?.Navigation?.openAlertDialog) {
+      await Xrm.Navigation.openAlertDialog({
+        text: message,
+      });
+    }
   }
 }