add DatabaseURLParamPath to reduce duplicated code and make SQ happy

Author: bhagatparwinder

bcda/aws/parameters.go

@@ -7,6 +7,11 @@ import (
 	"github.com/aws/aws-sdk-go-v2/service/ssm"
 )
 
+// DatabaseURLParamPath returns the SSM parameter path for the API DATABASE_URL (sensitive).
+func DatabaseURLParamPath(env string) string {
+	return fmt.Sprintf("/bcda/%s/sensitive/api/DATABASE_URL", env)
+}
+
 // Returns the value of a single parameter from the SSM Parameter Store
 func GetParameter(ctx context.Context, client *ssm.Client, keyname string) (string, error) {
 	withDecryption := true

bcda/lambda/admin_aco_deny/main.go

@@ -99,7 +99,7 @@ func getAWSParams(ctx context.Context) (awsParams, error) {
 	}
 	ssmClient := ssm.NewFromConfig(cfg)
 
-	dbURLName := fmt.Sprintf("/bcda/%s/sensitive/api/DATABASE_URL", env)
+	dbURLName := bcdaaws.DatabaseURLParamPath(env)
 	slackParamName := "/slack/token/workflow-alerts"
 	paramNames := []string{slackParamName, dbURLName}
 	params, err := bcdaaws.GetParameters(ctx, ssmClient, paramNames)

bcda/lambda/admin_create_aco/main.go

@@ -143,7 +143,7 @@ func getAWSParams(ctx context.Context) (awsParams, error) {
 	}
 	ssmClient := ssm.NewFromConfig(cfg)
 
-	dbURLName := fmt.Sprintf("/bcda/%s/sensitive/api/DATABASE_URL", env)
+	dbURLName := bcdaaws.DatabaseURLParamPath(env)
 	slackParamName := "/slack/token/workflow-alerts"
 	paramNames := []string{slackParamName, dbURLName}
 	params, err := bcdaaws.GetParameters(ctx, ssmClient, paramNames)

bcda/lambda/admin_create_aco_creds/aws.go

@@ -23,7 +23,7 @@ func getAWSParams(ctx context.Context) (awsParams, error) {
 	env := adjustedEnv()
 
 	slackParamName := "/slack/token/workflow-alerts"
-	dbURLName := fmt.Sprintf("/bcda/%s/sensitive/api/DATABASE_URL", env)
+	dbURLName := bcdaaws.DatabaseURLParamPath(env)
 	ssasURLName := fmt.Sprintf("/bcda/%s/sensitive/api/SSAS_URL", env)
 	clientIDName := fmt.Sprintf("/bcda/%s/sensitive/api/BCDA_SSAS_CLIENT_ID", env)
 	clientSecretName := fmt.Sprintf("/bcda/%s/sensitive/api/BCDA_SSAS_SECRET", env)

bcda/lambda/admin_create_group/main.go

@@ -149,7 +149,7 @@ func setupEnv(ctx context.Context) (string, error) {
 	ssmClient := ssm.NewFromConfig(cfg)
 
 	slackParamName := "/slack/token/workflow-alerts"
-	dbURLName := fmt.Sprintf("/bcda/%s/sensitive/api/DATABASE_URL", env)
+	dbURLName := bcdaaws.DatabaseURLParamPath(env)
 	ssasURLName := fmt.Sprintf("/bcda/%s/sensitive/api/SSAS_URL", env)
 	ssasClientName := fmt.Sprintf("/bcda/%s/sensitive/api/BCDA_SSAS_CLIENT_ID", env)
 	ssasSecretName := fmt.Sprintf("/bcda/%s/sensitive/api/BCDA_SSAS_SECRET", env)

bcda/lambda/cclf/main.go

@@ -64,7 +64,7 @@ func attributionImportHandler(ctx context.Context, sqsEvent events.SQSEvent) (st
 		o.Credentials = appCreds
 	})
 
-	dbURL, err := bcdaaws.GetParameter(ctx, ssmClient, fmt.Sprintf("/bcda/%s/sensitive/api/DATABASE_URL", env))
+	dbURL, err := bcdaaws.GetParameter(ctx, ssmClient, bcdaaws.DatabaseURLParamPath(env))
 	if err != nil {
 		logger.Error("failed to load DB URL")
 		return "", err

bcda/lambda/optout/main.go

@@ -65,7 +65,7 @@ func optOutImportHandler(ctx context.Context, sqsEvent events.SQSEvent) (string,
 		o.Credentials = appCreds
 	})
 
-	dbURL, err := bcdaaws.GetParameter(ctx, ssmClient, fmt.Sprintf("/bcda/%s/sensitive/api/DATABASE_URL", env))
+	dbURL, err := bcdaaws.GetParameter(ctx, ssmClient, bcdaaws.DatabaseURLParamPath(env))
 	if err != nil {
 		logger.Error("failed to load DB URL")
 		return "", err